OCPBUGS-17049: update lastSyncGeneration in STS flow sync success

[bentito]

Should now be properly setting the lastSyncGeneration as per the non-STS flow.

[openshift-ci-robot]

@bentito: No Jira issue with key OCP-17049 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

Should now be properly be setting the lastSyncGeneration as per the non-STS flow.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[bentito]

/jira refresh

[openshift-ci-robot]

@bentito: No Jira issue with key OCP-17049 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@bentito: The referenced Jira(s) [OCP-17049] could not be located, all automatically applied jira labels will be removed.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@bentito: This pull request references Jira Issue OCPBUGS-17049, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.0) matches configured target version for branch (4.14.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @fxierh

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Should now be properly be setting the lastSyncGeneration as per the non-STS flow.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@bentito: This pull request references Jira Issue OCPBUGS-17049, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.0) matches configured target version for branch (4.14.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @fxierh

In response to this:

Should now be properl setting the lastSyncGeneration as per the non-STS flow.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@bentito: This pull request references Jira Issue OCPBUGS-17049, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.0) matches configured target version for branch (4.14.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @fxierh

In response to this:

Should now be properly setting the lastSyncGeneration as per the non-STS flow.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@bentito: This pull request references Jira Issue OCPBUGS-17049, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.0) matches configured target version for branch (4.14.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @fxierh

In response to this:

Should now be properly setting the lastSyncGeneration as per the non-STS flow.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[fxierh]

@bentito Looks like r.Client.Status().Update(context.Background(), cr) is not called on the cr object with lastSyncGeneration updated.

[codecov]

Codecov Report

Merging #585 (17a91eb) into master (736d08b) will increase coverage by 0.41%.
Report is 6 commits behind head on master.
The diff coverage is 0.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #585      +/-   ##
==========================================
+ Coverage   48.12%   48.54%   +0.41%     
==========================================
  Files          94       94              
  Lines       11567    11703     +136     
==========================================
+ Hits         5567     5681     +114     
- Misses       5390     5416      +26     
+ Partials      610      606       -4     

Files Changed	Coverage Δ
...redentialsrequest/credentialsrequest_controller.go	48.55% <0.00%> (-0.38%)	⬇️

... and 1 file with indirect coverage changes

[bentito]

@bentito Looks like r.Client.Status().Update(context.Background(), cr) is not called on the cr object with lastSyncGeneration updated.

@fxierh yep, thanks, added the same call to the utility function UpdateStatus() that the non-STS flow uses.

[newtonheath]

@bentito - we ready?

[bentito]

@bentito - we ready?

if it looks good to @abutcher then yes

[abutcher]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abutcher, bentito

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [abutcher]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@bentito: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@bentito: Jira Issue OCPBUGS-17049: All pull requests linked via external trackers have merged:

• openshift/cloud-credential-operator#585

Jira Issue OCPBUGS-17049 has been moved to the MODIFIED state.

In response to this:

Should now be properly setting the lastSyncGeneration as per the non-STS flow.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.