pkg/aws/actuator: Drop comment which suggested passthrough permission verification #590
Conversation
… verification 17bd3ee (handle bootstrap pod user-defined mode, 2020-07-29, openshift#228) moved the CheckPermissionsUsingQueryClient down to a !=Passthrough block, so drop the comment which suggested passthrough creds were checked to confirm sufficient permissions.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abutcher, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #590 +/- ##
=======================================
Coverage 48.19% 48.19%
=======================================
Files 96 96
Lines 11635 11635
=======================================
Hits 5607 5607
Misses 5415 5415
Partials 613 613
|
|
Overriding labels for a comment correction. /label px-approved |
openshift-ci
bot
added
px-approved
|
/retest-required |
|
@wking: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
17bd3ee (#228) moved the
CheckPermissionsUsingQueryClientdown to a!=Passthroughblock, so drop the comment which suggested passthrough creds were checked to confirm sufficient permissions.