Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-17719: Double timeout delays for managed identity creation and role assignment from 2 to 4 minutes. #591

Merged
merged 1 commit into from Aug 16, 2023

Conversation

abutcher
Copy link
Member

@abutcher abutcher commented Aug 15, 2023

Replication delay has exceeded the current 2 minute timeout frequently with the addition of more custom roles created via CredentialsRequests. This change doubles the current timeout, increasing the timeout to 4 minutes.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 15, 2023
@openshift-ci-robot
Copy link
Contributor

@abutcher: This pull request references Jira Issue OCPBUGS-17719, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abutcher
Copy link
Member Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 15, 2023
@openshift-ci-robot
Copy link
Contributor

@abutcher: This pull request references Jira Issue OCPBUGS-17719, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abutcher
Copy link
Member Author

/assign @jstuever

@openshift-ci-robot
Copy link
Contributor

@abutcher: This pull request references Jira Issue OCPBUGS-17719, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

Replication delay has exceeded the current 2 minute timeout in other regions. This change doubles the current timeout, increasing the timeout to 4 minutes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 15, 2023
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #591 (14279f0) into master (b53516f) will increase coverage by 0.91%.
Report is 2 commits behind head on master.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #591      +/-   ##
==========================================
+ Coverage   48.19%   49.10%   +0.91%     
==========================================
  Files          96       96              
  Lines       11635    11911     +276     
==========================================
+ Hits         5607     5849     +242     
+ Misses       5415     5404      -11     
- Partials      613      658      +45     
Files Changed Coverage Δ
...md/provisioning/azure/create_managed_identities.go 60.13% <0.00%> (ø)

... and 1 file with indirect coverage changes

@openshift-ci-robot
Copy link
Contributor

@abutcher: This pull request references Jira Issue OCPBUGS-17719, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

Replication delay has exceeded the current 2 minute timeout frequently with the addition of more custom roles created via CredentialsRequests. This change doubles the current timeout, increasing the timeout to 4 minutes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jstuever
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 16, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abutcher, jstuever

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 16, 2023

@abutcher: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 2c3298b into openshift:master Aug 16, 2023
10 checks passed
@openshift-ci-robot
Copy link
Contributor

@abutcher: Jira Issue OCPBUGS-17719: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-17719 has been moved to the MODIFIED state.

In response to this:

Replication delay has exceeded the current 2 minute timeout frequently with the addition of more custom roles created via CredentialsRequests. This change doubles the current timeout, increasing the timeout to 4 minutes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants