New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPVE-647: annotate manifests with capability name #594
Conversation
@qJkee: This pull request references OCPVE-647 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest-required |
@qJkee: This pull request references OCPVE-647 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #594 +/- ##
==========================================
+ Coverage 48.42% 48.87% +0.45%
==========================================
Files 96 96
Lines 11741 12044 +303
==========================================
+ Hits 5686 5887 +201
- Misses 5425 5511 +86
- Partials 630 646 +16
|
/hold until openshift/api#1571 gets merged |
@qJkee: This pull request references OCPVE-647 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
/lgtm |
Depends on openshift/api#1571 |
86a1337
to
fb43d39
Compare
add CloudCredential capability name to all manifests to make component optional
Why do we annotate the manifests under |
@fxierh |
This makes me wonder why we maintain two sets of manifests, i.e. the |
modify render function to return nothing in case if CCO is disabled in the cluster
Bump priority of the manifests in CVO order. This change is needed because some operators had higher priority for credentials request than actual CRD. This change solving the issue.
/retest |
Well, it's because of bindata |
/retest |
/test e2e-upgrade |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dlom, qJkee The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
@qJkee: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[ART PR BUILD NOTIFIER] This PR has been included in build ose-cloud-credential-operator-container-v4.16.0-202312071150.p0.gba0e0a8.assembly.stream for distgit ose-cloud-credential-operator. |
add CloudCredential capability name to all manifests to make component optional
Also, i had to modify the
render
function. Now, if capability is disabled, we do render nothing