OCPBUGS-18246: Add networkResourceGroupName parameter for Azure #597

dlom · 2023-09-05T23:49:11Z

This optional paramter can be used to specify a resource group containing existing network resources, which (if provided) will be scoped to several network-related operators in addition to the main installation resource group

xref: OCPBUGS-18246

Virtual network related permissions were discovered in the following credentials requests (recent nightly):

0000_30_machine-api-operator_00_credentials-request.yaml
53:    - Microsoft.Network/virtualNetworks/delete
54:    - Microsoft.Network/virtualNetworks/read
55:    - Microsoft.Network/virtualNetworks/subnets/delete
56:    - Microsoft.Network/virtualNetworks/subnets/join/action
57:    - Microsoft.Network/virtualNetworks/subnets/read
58:    - Microsoft.Network/virtualNetworks/subnets/write
59:    - Microsoft.Network/virtualNetworks/write

0000_50_cluster-storage-operator_03_credentials_request_azure_file.yaml
17:    - Microsoft.Network/virtualNetworks/subnets/read
18:    - Microsoft.Network/virtualNetworks/subnets/write

0000_50_cluster-network-operator_02-cncc-credentials.yaml
19:    - Microsoft.Network/virtualNetworks/read

/assign @abutcher
/cc @jstuever

openshift-ci-robot · 2023-09-05T23:49:16Z

@dlom: This pull request references Jira Issue OCPBUGS-18246, which is invalid:

expected the bug to target the "4.14.0" version, but it targets "4.14.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This optional paramter can be used to specify a resource group containing existing network resources, which (if provided) will be scoped to several network-related operators in addition to the main installation resource group

xref: OCPBUGS-18246

Virtual network related permissions were discovered in the following credentials requests (recent nightly):
0000_30_machine-api-operator_00_credentials-request.yaml
53:    - Microsoft.Network/virtualNetworks/delete
54:    - Microsoft.Network/virtualNetworks/read
55:    - Microsoft.Network/virtualNetworks/subnets/delete
56:    - Microsoft.Network/virtualNetworks/subnets/join/action
57:    - Microsoft.Network/virtualNetworks/subnets/read
58:    - Microsoft.Network/virtualNetworks/subnets/write
59:    - Microsoft.Network/virtualNetworks/write

0000_50_cluster-storage-operator_03_credentials_request_azure_file.yaml
17:    - Microsoft.Network/virtualNetworks/subnets/read
18:    - Microsoft.Network/virtualNetworks/subnets/write

0000_50_cluster-network-operator_02-cncc-credentials.yaml
19:    - Microsoft.Network/virtualNetworks/read
/assign @abutcher
/cc @jstuever

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-09-05T23:50:31Z

@dlom: This pull request references Jira Issue OCPBUGS-18246, which is invalid:

expected the bug to target the "4.14.0" version, but it targets "4.14.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

This optional paramter can be used to specify a resource group containing existing network resources, which (if provided) will be scoped to several network-related operators in addition to the main installation resource group

xref: OCPBUGS-18246

Virtual network related permissions were discovered in the following credentials requests (recent nightly):
0000_30_machine-api-operator_00_credentials-request.yaml
53:    - Microsoft.Network/virtualNetworks/delete
54:    - Microsoft.Network/virtualNetworks/read
55:    - Microsoft.Network/virtualNetworks/subnets/delete
56:    - Microsoft.Network/virtualNetworks/subnets/join/action
57:    - Microsoft.Network/virtualNetworks/subnets/read
58:    - Microsoft.Network/virtualNetworks/subnets/write
59:    - Microsoft.Network/virtualNetworks/write

0000_50_cluster-storage-operator_03_credentials_request_azure_file.yaml
17:    - Microsoft.Network/virtualNetworks/subnets/read
18:    - Microsoft.Network/virtualNetworks/subnets/write

0000_50_cluster-network-operator_02-cncc-credentials.yaml
19:    - Microsoft.Network/virtualNetworks/read
/assign @abutcher
/cc @jstuever

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

codecov · 2023-09-06T21:20:55Z

Codecov Report

Merging #597 (5cb042b) into master (2c3298b) will decrease coverage by 0.09%.
The diff coverage is 4.54%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #597      +/-   ##
==========================================
- Coverage   48.19%   48.10%   -0.09%     
==========================================
  Files          96       96              
  Lines       11635    11656      +21     
==========================================
  Hits         5607     5607              
- Misses       5415     5435      +20     
- Partials      613      614       +1

Files Changed	Coverage Δ
pkg/cmd/provisioning/azure/azure.go	`0.00% <ø> (ø)`
pkg/cmd/provisioning/azure/create_all.go	`0.00% <0.00%> (ø)`
...md/provisioning/azure/create_managed_identities.go	`58.58% <7.69%> (-1.55%)`	⬇️

abutcher · 2023-09-12T15:11:09Z

/test e2e-azure-manual-oidc

abutcher

Didn't expect that the CSI driver would need subnet permissions but changes look good to me. Added comments for updating the parameter description to make it clearer that its related to pre-existing VNet for use in install-config.

pkg/cmd/provisioning/azure/create_all.go

pkg/cmd/provisioning/azure/create_managed_identities.go

jstuever · 2023-09-19T18:45:35Z

/test e2e-azure-manual-oidc

This paramter can be used to specify a resource group containing existing network resources, which will be scoped to several network-related operators in addition to the main installation resource group (if one is provided)

openshift-ci · 2023-09-20T21:26:59Z

@dlom: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

dlom · 2023-09-21T18:43:25Z

/jira refresh

openshift-ci-robot · 2023-09-21T18:43:31Z

@dlom: This pull request references Jira Issue OCPBUGS-18246, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.15.0) matches configured target version for branch (4.15.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jianping-shu

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jianping-shu · 2023-09-22T01:56:24Z

@huangmingxia PTAL

jstuever · 2023-09-22T18:07:39Z

/unassign @abutcher
/assign

jstuever · 2023-09-22T18:10:56Z

/hold
We will be requiring QE approval before we merge. However, this repo is not configured for that, yet. I'm placing this on hold until we get the qe-approval label.

jstuever · 2023-09-22T18:11:11Z

/lgtm

jstuever · 2023-09-22T18:12:40Z

/assign @jianping-shu
For qe-approved

openshift-ci · 2023-09-22T18:12:54Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dlom, jstuever

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [dlom,jstuever]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jianping-shu · 2023-09-25T14:16:34Z

@huangmingxia Pls. verify and add 'qe-approved'

huangmingxia · 2023-09-25T14:57:21Z

Thank you, it is being tested, but the cluster has not been installed successfully at present, I am checking the reason for the installation failure now.

huangmingxia · 2023-09-27T04:36:15Z

/label qe-approved
Cluster install successfully.

dlom · 2023-09-27T06:01:56Z

/unhold

openshift-ci-robot · 2023-09-27T06:04:30Z

@dlom: Jira Issue OCPBUGS-18246: All pull requests linked via external trackers have merged:

openshift/cloud-credential-operator#597

Jira Issue OCPBUGS-18246 has been moved to the MODIFIED state.

In response to this:

This optional paramter can be used to specify a resource group containing existing network resources, which (if provided) will be scoped to several network-related operators in addition to the main installation resource group

xref: OCPBUGS-18246

Virtual network related permissions were discovered in the following credentials requests (recent nightly):
0000_30_machine-api-operator_00_credentials-request.yaml
53:    - Microsoft.Network/virtualNetworks/delete
54:    - Microsoft.Network/virtualNetworks/read
55:    - Microsoft.Network/virtualNetworks/subnets/delete
56:    - Microsoft.Network/virtualNetworks/subnets/join/action
57:    - Microsoft.Network/virtualNetworks/subnets/read
58:    - Microsoft.Network/virtualNetworks/subnets/write
59:    - Microsoft.Network/virtualNetworks/write

0000_50_cluster-storage-operator_03_credentials_request_azure_file.yaml
17:    - Microsoft.Network/virtualNetworks/subnets/read
18:    - Microsoft.Network/virtualNetworks/subnets/write

0000_50_cluster-network-operator_02-cncc-credentials.yaml
19:    - Microsoft.Network/virtualNetworks/read
/assign @abutcher
/cc @jstuever

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dlom · 2023-09-27T17:45:31Z

/backport release-4.14

dlom · 2023-09-27T17:52:46Z

/cherry-pick release-4.14

openshift-cherrypick-robot · 2023-09-27T17:53:40Z

@dlom: new pull request created: #602

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot assigned abutcher Sep 5, 2023

openshift-ci bot requested a review from jstuever September 5, 2023 23:49

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2023

dlom force-pushed the OCPBUGS-18246 branch from ba71d56 to e8e413a Compare September 6, 2023 19:26

abutcher reviewed Sep 12, 2023

View reviewed changes

pkg/cmd/provisioning/azure/create_all.go Outdated Show resolved Hide resolved

pkg/cmd/provisioning/azure/create_managed_identities.go Outdated Show resolved Hide resolved

Add networkResourceGroupName parameter for Azure

5cb042b

This paramter can be used to specify a resource group containing existing network resources, which will be scoped to several network-related operators in addition to the main installation resource group (if one is provided)

dlom force-pushed the OCPBUGS-18246 branch from e8e413a to 5cb042b Compare September 20, 2023 18:45

openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Sep 21, 2023

openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Sep 21, 2023

openshift-ci bot requested a review from jianping-shu September 21, 2023 18:43

openshift-ci bot assigned jstuever and unassigned abutcher Sep 22, 2023

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 22, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 22, 2023

openshift-ci bot assigned jianping-shu Sep 22, 2023

openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Sep 27, 2023

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 27, 2023

openshift-merge-robot merged commit 286b3c5 into openshift:master Sep 27, 2023
10 checks passed

huangmingxia mentioned this pull request Sep 27, 2023

[OCPSTRAT-506] Add CI for Azure Workload Identity disconnected. openshift/release#43741

Merged

openshift-cherrypick-robot mentioned this pull request Sep 27, 2023

[release-4.14] OCPBUGS-19865: Add networkResourceGroupName parameter for Azure #602

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OCPBUGS-18246: Add networkResourceGroupName parameter for Azure #597

OCPBUGS-18246: Add networkResourceGroupName parameter for Azure #597

dlom commented Sep 5, 2023 •

edited

openshift-ci-robot commented Sep 5, 2023

openshift-ci-robot commented Sep 5, 2023

codecov bot commented Sep 6, 2023 •

edited

abutcher commented Sep 12, 2023

abutcher left a comment

jstuever commented Sep 19, 2023

openshift-ci bot commented Sep 20, 2023

dlom commented Sep 21, 2023

openshift-ci-robot commented Sep 21, 2023

jianping-shu commented Sep 22, 2023

jstuever commented Sep 22, 2023

jstuever commented Sep 22, 2023

jstuever commented Sep 22, 2023

jstuever commented Sep 22, 2023

openshift-ci bot commented Sep 22, 2023

jianping-shu commented Sep 25, 2023

huangmingxia commented Sep 25, 2023

huangmingxia commented Sep 27, 2023

dlom commented Sep 27, 2023

openshift-ci-robot commented Sep 27, 2023

dlom commented Sep 27, 2023

dlom commented Sep 27, 2023

openshift-cherrypick-robot commented Sep 27, 2023

OCPBUGS-18246: Add networkResourceGroupName parameter for Azure #597

OCPBUGS-18246: Add networkResourceGroupName parameter for Azure #597

Conversation

dlom commented Sep 5, 2023 • edited

openshift-ci-robot commented Sep 5, 2023

openshift-ci-robot commented Sep 5, 2023

codecov bot commented Sep 6, 2023 • edited

Codecov Report

abutcher commented Sep 12, 2023

abutcher left a comment

Choose a reason for hiding this comment

jstuever commented Sep 19, 2023

openshift-ci bot commented Sep 20, 2023

dlom commented Sep 21, 2023

openshift-ci-robot commented Sep 21, 2023

jianping-shu commented Sep 22, 2023

jstuever commented Sep 22, 2023

jstuever commented Sep 22, 2023

jstuever commented Sep 22, 2023

jstuever commented Sep 22, 2023

openshift-ci bot commented Sep 22, 2023

jianping-shu commented Sep 25, 2023

huangmingxia commented Sep 25, 2023

huangmingxia commented Sep 27, 2023

dlom commented Sep 27, 2023

openshift-ci-robot commented Sep 27, 2023

dlom commented Sep 27, 2023

dlom commented Sep 27, 2023

openshift-cherrypick-robot commented Sep 27, 2023

dlom commented Sep 5, 2023 •

edited

codecov bot commented Sep 6, 2023 •

edited