Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "CCO-421: *: split pod identity webhooks from core controller" #605

Closed
wants to merge 1 commit into from

Conversation

dgoodwin
Copy link
Contributor

@dgoodwin dgoodwin commented Oct 12, 2023

Reverts #592

Change unfortunately is full failing upgrade jobs on CI payload, likely on nightly payload shortly.

To re-introduce please unrevert this revert, layer in separate commit with fixes, and confirm success with /payload-job periodic-ci-openshift-release-master-ci-4.15-upgrade-from-stable-4.14-e2e-aws-ovn-upgrade

TRT-1299 has details on what I suspect may have gone wrong, it looks like the metrics endpoint is not on the right container perhaps.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 12, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 12, 2023

@dgoodwin: This pull request references CCO-421 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Reverts #592

Change unfortunately is full failing upgrade jobs on CI payload, likely on nightly payload shortly.

To re-introduce please unrevert this revert, layer in separate commit with fixes, and confirm success with /payload-job periodic-ci-openshift-release-master-ci-4.15-upgrade-from-stable-4.14-e2e-aws-ovn-upgrade

TRT-1299 has details on what I suspect may have gone wrong, it looks like the metrics endpoint is not on the right container perhaps.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 12, 2023

@dgoodwin: This pull request references CCO-421 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Reverts #592

Change unfortunately is full failing upgrade jobs on CI payload, likely on nightly payload shortly.

To re-introduce please unrevert this revert, layer in separate commit with fixes, and confirm success with /payload-job periodic-ci-openshift-release-master-ci-4.15-upgrade-from-stable-4.14-e2e-aws-ovn-upgrade

TRT-1299 has details on what I suspect may have gone wrong, it looks like the metrics endpoint is not on the right container perhaps.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dgoodwin
Copy link
Contributor Author

/close

Doubled with #604

@openshift-ci openshift-ci bot requested review from 2uasimojo and dlom October 12, 2023 14:22
@openshift-ci openshift-ci bot closed this Oct 12, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 12, 2023

@dgoodwin: Closed this PR.

In response to this:

/close

Doubled with #604

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 12, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dgoodwin
Once this PR has been reviewed and has the lgtm label, please assign 2uasimojo for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants