[release-4.14] OCPBUGS-21926: azure create-managed-identites to add cloud controller manager to network resource group

[openshift-cherrypick-robot]

This is an automated cherry-pick of #607

/assign sdodson

[openshift-ci-robot]

@openshift-cherrypick-robot: Jira Issue OCPBUGS-21745 has been cloned as Jira Issue OCPBUGS-21926. Will retitle bug to link to clone.
/retitle [release-4.14] OCPBUGS-21926: azure create-managed-identites to add cloud controller manager to network resource group

In response to this:

This is an automated cherry-pick of #607

/assign sdodson

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-21926, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.0) matches configured target version for branch (4.14.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
• dependent bug Jira Issue OCPBUGS-21745 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
• dependent Jira Issue OCPBUGS-21745 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0
• bug has dependents

Requesting review from QA contact:
/cc @jianping-shu

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #607

/assign sdodson

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sdodson]

/lgtm

[codecov]

Codecov Report

Merging #608 (8fc20b4) into release-4.14 (6956fe5) will not change coverage.
The diff coverage is 0.00%.

Additional details and impacted files

@@              Coverage Diff              @@
##           release-4.14     #608   +/-   ##
=============================================
  Coverage         48.10%   48.10%           
=============================================
  Files                96       96           
  Lines             11656    11656           
=============================================
  Hits               5607     5607           
  Misses             5435     5435           
  Partials            614      614           

Files	Coverage Δ
...md/provisioning/azure/create_managed_identities.go	58.58% <0.00%> (ø)

[sdodson]

/retest-required

[openshift-ci]

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[sdodson]

/hold
Testing by qe has identified additional gaps which should be addressed and full testing or this use case completed before we backport additional changes.

[jstuever]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jstuever, openshift-cherrypick-robot, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jstuever]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jstuever]

/hold cancel

[jstuever]

QE has cleared their concerns, and I have verified the functionality in 4.14. We are good to move forward here.

[jstuever]

/label backport-risk-assessed

[openshift-ci]

@jstuever: Can not set label backport-risk-assessed: Must be member in one of these teams: []

In response to this:

/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sdodson]

This change fixes a new feature of 4.14 so adding staff eng approved.

[jianping-shu]

Add @huangmingxia to verify

[huangmingxia]

/label cherry-pick-approved
Verification passed using image registry.build05.ci.openshift.org/ci-ln-rlz31lk/release:latest.

[openshift-ci-robot]

@openshift-cherrypick-robot: Jira Issue OCPBUGS-21926: All pull requests linked via external trackers have merged:

• openshift/cloud-credential-operator#608

Jira Issue OCPBUGS-21926 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #607

/assign sdodson

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.