Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snyk: exclude vendor/ #613

Merged
merged 1 commit into from Oct 31, 2023
Merged

Conversation

2uasimojo
Copy link
Member

...as we expect vulns in deps to be caught by the dep scan.

...as we expect vulns in deps to be caught by the dep scan.
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2023
@2uasimojo
Copy link
Member Author

/assign @dlom

This is working. security fail is expected at this point:

  • grpc dep update still needed.
  • low/med exclusions coming via release repo PR.

@dlom
Copy link
Contributor

dlom commented Oct 30, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 2uasimojo, dlom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 792dfb6 and 2 for PR HEAD f3f64d4 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 31, 2023

@2uasimojo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security f3f64d4 link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit a1ecc5a into openshift:master Oct 31, 2023
8 of 9 checks passed
@2uasimojo 2uasimojo deleted the snyk-exclude-vendor branch November 1, 2023 22:54
@2uasimojo
Copy link
Member Author

/cherry-pick release-4.16

@openshift-cherrypick-robot

@2uasimojo: new pull request could not be created: failed to create pull request against openshift/cloud-credential-operator#release-4.16 from head openshift-cherrypick-robot:cherry-pick-613-to-release-4.16: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between openshift:release-4.16 and openshift-cherrypick-robot:cherry-pick-613-to-release-4.16"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"}

In response to this:

/cherry-pick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@2uasimojo
Copy link
Member Author

/cherry-pick release-4.15

@openshift-cherrypick-robot

@2uasimojo: new pull request could not be created: failed to create pull request against openshift/cloud-credential-operator#release-4.15 from head openshift-cherrypick-robot:cherry-pick-613-to-release-4.15: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between openshift:release-4.15 and openshift-cherrypick-robot:cherry-pick-613-to-release-4.15"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"}

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@2uasimojo
Copy link
Member Author

/cherry-pick release-4.14

@openshift-cherrypick-robot

@2uasimojo: new pull request created: #615

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants