New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CCO-440: Bump k8s deps to 0.28.3 #614
CCO-440: Bump k8s deps to 0.28.3 #614
Conversation
/assign @jstuever |
6ef9d04
to
94ded11
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #614 +/- ##
=======================================
Coverage 47.90% 47.90%
=======================================
Files 96 96
Lines 11680 11680
=======================================
Hits 5595 5595
Misses 5465 5465
Partials 620 620 |
81c67f3
to
5ad2763
Compare
/retest |
1 similar comment
/retest |
/retest I don't know how to look at these failures to see if they're flakes. If this keeps failing I'll probably need some help with that. |
/retest |
Not a flake. Leader election is using |
CCO-440
5ad2763
to
1259654
Compare
Done in #627. |
/retest |
1 similar comment
/retest |
@2uasimojo: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
I think we decided it was acceptable to wait until next week to land this. |
/label acknowledge-critical-fixes-only Per @wallylewis in CCO-440 we're allowed to do this for k8s bumps. |
/jira refresh |
@2uasimojo: No Jira issue is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@2uasimojo: This pull request references CCO-440 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 2uasimojo, dlom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[ART PR BUILD NOTIFIER] This PR has been included in build ose-cloud-credential-operator-container-v4.15.0-202311160232.p0.g9507066.assembly.stream for distgit ose-cloud-credential-operator. |
CCO-440
NOTE: Adapted hacks from here to make this work.