Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCO-440: Bump k8s deps to 0.28.3 #614

Merged
merged 1 commit into from Nov 15, 2023

Conversation

2uasimojo
Copy link
Member

@2uasimojo 2uasimojo commented Nov 1, 2023

CCO-440

NOTE: Adapted hacks from here to make this work.

@2uasimojo
Copy link
Member Author

/assign @jstuever

@openshift-ci openshift-ci bot requested review from dlom and lleshchi November 1, 2023 19:39
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 1, 2023
@2uasimojo 2uasimojo force-pushed the CCO-440/k8s-1.28 branch 2 times, most recently from 6ef9d04 to 94ded11 Compare November 1, 2023 20:26
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #614 (1259654) into master (5a6da9c) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #614   +/-   ##
=======================================
  Coverage   47.90%   47.90%           
=======================================
  Files          96       96           
  Lines       11680    11680           
=======================================
  Hits         5595     5595           
  Misses       5465     5465           
  Partials      620      620           

@2uasimojo 2uasimojo force-pushed the CCO-440/k8s-1.28 branch 3 times, most recently from 81c67f3 to 5ad2763 Compare November 3, 2023 21:56
@2uasimojo
Copy link
Member Author

/retest

1 similar comment
@2uasimojo
Copy link
Member Author

/retest

@2uasimojo
Copy link
Member Author

/retest

I don't know how to look at these failures to see if they're flakes. If this keeps failing I'll probably need some help with that.

@jstuever
Copy link
Contributor

/retest

@jstuever
Copy link
Contributor

Not a flake. Leader election is using configmapsleases, which is not available in 1.28. We will need to migrate to resourcelock.LeasesResourceLock, which I will do in another PR.

@2uasimojo
Copy link
Member Author

Not a flake. Leader election is using configmapsleases, which is not available in 1.28. We will need to migrate to resourcelock.LeasesResourceLock, which I will do in another PR.

Done in #627.

@2uasimojo
Copy link
Member Author

/retest

1 similar comment
@2uasimojo
Copy link
Member Author

/retest

Copy link
Contributor

openshift-ci bot commented Nov 15, 2023

@2uasimojo: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@2uasimojo
Copy link
Member Author

tide Pending — Not mergeable. Needs acknowledge-critical-fixes-only label.

I think we decided it was acceptable to wait until next week to land this.

@2uasimojo
Copy link
Member Author

2uasimojo commented Nov 15, 2023

/label acknowledge-critical-fixes-only

Per @wallylewis in CCO-440 we're allowed to do this for k8s bumps.

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Nov 15, 2023
@2uasimojo
Copy link
Member Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@2uasimojo: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@2uasimojo 2uasimojo changed the title Bump k8s deps to 0.28.3 CCO-440: Bump k8s deps to 0.28.3 Nov 15, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 15, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 15, 2023

@2uasimojo: This pull request references CCO-440 which is a valid jira issue.

In response to this:

CCO-440

NOTE: Adapted hacks from here to make this work.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dlom
Copy link
Contributor

dlom commented Nov 15, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2023
Copy link
Contributor

openshift-ci bot commented Nov 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 2uasimojo, dlom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 9507066 into openshift:master Nov 15, 2023
10 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cloud-credential-operator-container-v4.15.0-202311160232.p0.g9507066.assembly.stream for distgit ose-cloud-credential-operator.
All builds following this will include this PR.

@2uasimojo 2uasimojo deleted the CCO-440/k8s-1.28 branch November 16, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants