CCO-244: gcp-ro-credentialrequest to use granular permissions #626
Conversation
Switch the gcp-ro credential request to use granular permissions. It is only used by the actuator.needsUpdate() function. Everything else escalates to the root service account. The needsUpdate() function currently requires the following permissions as per the specified function calls. iam.roles.get: getPermissionsFromRoles() serviceAccountNeedsPermissionsUpdate() iam.serviceAccountKeys.list serviceAccountKeyExists() iam.serviceAccounts.get: GetServiceAccount() serviceAccountNeedsPermissionsUpdate() resourcemanager.projects.get: checkServicesEnabled() resourcemanager.projects.getIamPolicy: serviceAccountNeedsPermissionsUpdate() serviceusage.services.list: checkServicesEnabled()
openshift-ci-robot
added
the
jira/valid-reference
|
@jstuever: This pull request references CCO-224 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
jstuever
changed the title
|
@jstuever: This pull request references CCO-244 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
approved
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/assign @dlom |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dlom, jstuever The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/override ci/prow/security |
|
@dlom: Overrode contexts on behalf of dlom: ci/prow/security In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/label qe-approved Hi @jstuever @dlom Using image |
openshift-ci
bot
added
the
qe-approved
|
@jstuever: This pull request references CCO-244 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/payload 4.15 nightly blocking |
|
@jstuever: trigger 8 job(s) of type blocking for the nightly release of OCP 4.15
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5ad070e0-946d-11ee-9091-0086eb9d1944-0 |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
@jstuever: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-cloud-credential-operator-container-v4.15.0-202312070130.p0.gda655f8.assembly.stream for distgit ose-cloud-credential-operator. |
Switch the gcp-ro credential request to use granular permissions. It is only used by the actuator.needsUpdate() function. Everything else escalates to the root service account. The needsUpdate() function currently requires the following permissions as per the specified function calls.
iam.roles.get:
getPermissionsFromRoles()
serviceAccountNeedsPermissionsUpdate()
iam.serviceAccountKeys.list
serviceAccountKeyExists()
iam.serviceAccounts.get:
GetServiceAccount()
serviceAccountNeedsPermissionsUpdate()
resourcemanager.projects.get:
checkServicesEnabled()
resourcemanager.projects.getIamPolicy:
serviceAccountNeedsPermissionsUpdate()
serviceusage.services.list:
checkServicesEnabled()