OCPBUGS-20478: Explicitly set the vsphere secret credential data on sync. #628
Conversation
openshift-ci-robot
added
jira/severity-important
|
@jstuever: This pull request references Jira Issue OCPBUGS-20478, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
jira/invalid-bug
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
/jira refresh |
|
@jstuever: This pull request references Jira Issue OCPBUGS-20478, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
approved
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@jstuever: This pull request references Jira Issue OCPBUGS-20478, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test |
|
@jstuever: The
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test e2e-azure |
The behavior previously changed to patching the credential secrets as opposed to updating them. As a result, sometimes when a credential is changed it can continue to have pieces of the old credential. This change overrides the entire credential data to be explicitly set to the new credential. This will remove all old credential data when syncing the new credential.
jstuever
force-pushed
the
OCPBUGS-20478
branch
from
a054632
to
3d13848
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #628 +/- ##
==========================================
- Coverage 47.90% 47.89% -0.01%
==========================================
Files 96 96
Lines 11680 11679 -1
==========================================
- Hits 5595 5594 -1
Misses 5465 5465
Partials 620 620
|
|
/retest |
|
@jstuever can you add unit test to this code to simulate the problem in assisted installer? thanks |
|
I built my own OCP release with this PR in it, and I ran an install on vsphere, the issue looks to be fixed: |
|
@jstuever can you merge it, please? |
|
/retest |
jstuever
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/label acknowledge-critical-fixes-only |
openshift-ci
bot
added
the
acknowledge-critical-fixes-only
|
/assign @dlom |
|
/cherry-pick release-4.14 |
|
@jstuever: once the present PR merges, I will cherry-pick it on top of release-4.14 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
jstuever
changed the title
|
@jstuever: This pull request references Jira Issue OCPBUGS-20478, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dlom, jstuever The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test e2e-hypershift |
|
@jstuever: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@jstuever: Jira Issue OCPBUGS-20478: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-20478 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@jstuever: new pull request created: #629 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-cloud-credential-operator-container-v4.15.0-202311191150.p0.g3c72c02.assembly.stream for distgit ose-cloud-credential-operator. |
|
Fix included in accepted release 4.15.0-0.nightly-2023-11-19-145055 |
The behavior recently changed to patching the credential secrets as opposed to updating them. As a result, sometimes when a credential is changed it can continue to have pieces of the old credential.
This change overrides the entire vphere credential data to be explicitly set to the new credential. This will remove all old credential data when syncing the new credential.