Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: Update docs/sts.md #634

Merged
merged 1 commit into from Dec 13, 2023

Conversation

shirady
Copy link
Contributor

@shirady shirady commented Nov 30, 2023

  1. Add a comment about the name flag in step 3 of in-place migration.

Add comment about the name flag in step 3 of in-place migration.

Signed-off-by: shirady <57721533+shirady@users.noreply.github.com>
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 30, 2023
Copy link
Contributor

openshift-ci bot commented Nov 30, 2023

Hi @shirady. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@shirady
Copy link
Contributor Author

shirady commented Nov 30, 2023

HI,
I would also note that step 6 is not clear "Wait for the kube-apiserver pods to be updated with the new config" - what exactly are we waiting for? (what is the state before and what is the state after?)

@jstuever
Copy link
Contributor

/cc @dlom

@openshift-ci openshift-ci bot requested a review from dlom December 11, 2023 21:39
@dlom
Copy link
Contributor

dlom commented Dec 11, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2023
Copy link
Contributor

openshift-ci bot commented Dec 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dlom, shirady

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 11, 2023
@jstuever
Copy link
Contributor

/retitle NOJIRA: Update docs/sts.md

@openshift-ci openshift-ci bot changed the title Update docs/sts.md NOJIRA: Update docs/sts.md Dec 12, 2023
@jstuever
Copy link
Contributor

/retitle NO-JIRA: Update docs/sts.md

@openshift-ci openshift-ci bot changed the title NOJIRA: Update docs/sts.md NO-JIRA: Update docs/sts.md Dec 12, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 12, 2023
@openshift-ci-robot
Copy link
Contributor

@shirady: This pull request explicitly references no jira issue.

In response to this:

  1. Add a comment about the name flag in step 3 of in-place migration.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 657cc62 and 2 for PR HEAD e1f6440 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 3d03585 and 1 for PR HEAD e1f6440 in total

Copy link
Contributor

openshift-ci bot commented Dec 12, 2023

@shirady: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit cdc7dc8 into openshift:master Dec 13, 2023
2 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cloud-credential-operator-container-v4.16.0-202312130634.p0.gcdc7dc8.assembly.stream for distgit ose-cloud-credential-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants