Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCO-388: operator/cmd: allow configuring the leader election namespace #636

Conversation

stevekuznetsov
Copy link
Contributor

In HyperShift and similar deployment topologies, the leader election lock for this operator will not be in the core namespace for the host, but in the tenant namespace.

In HyperShift and similar deployment topologies, the leader election
lock for this operator will not be in the core namespace for the host,
but in the tenant namespace.

Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 4, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 4, 2023

@stevekuznetsov: This pull request references CCO-388 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

In HyperShift and similar deployment topologies, the leader election lock for this operator will not be in the core namespace for the host, but in the tenant namespace.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

openshift-ci bot commented Dec 4, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: stevekuznetsov
Once this PR has been reviewed and has the lgtm label, please assign 2uasimojo for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stevekuznetsov
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 4, 2023
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Merging #636 (ae26e90) into master (c721882) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #636   +/-   ##
=======================================
  Coverage   48.42%   48.42%           
=======================================
  Files          96       96           
  Lines       11741    11741           
=======================================
  Hits         5686     5686           
  Misses       5425     5425           
  Partials      630      630           

Copy link
Contributor

openshift-ci bot commented Dec 4, 2023

@stevekuznetsov: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-hypershift ae26e90 link true /test e2e-hypershift

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants