OCPBUGS-23178: Enable GCP sync to undelete custom roles

[jstuever]

Previously, the GCP sync would error when attempting to add permissions to a custom role that was deleted and pending pruning. This change ensures the custom roles are undeleted.

[openshift-ci-robot]

@jstuever: This pull request references Jira Issue OCPBUGS-23178, which is invalid:

• expected the bug to target the "4.15.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Previously, the GCP sync would error when attempting to add permissions to a custom role that was deleted and pending pruning. This change ensures the custom roles are undeleted.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jstuever]

/jira refresh

[openshift-ci-robot]

@jstuever: This pull request references Jira Issue OCPBUGS-23178, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.15.0) matches configured target version for branch (4.15.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @huangmingxia

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov]

Codecov Report

Merging #637 (a762248) into master (c721882) will decrease coverage by 0.11%.
The diff coverage is 3.70%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #637      +/-   ##
==========================================
- Coverage   48.42%   48.32%   -0.11%     
==========================================
  Files          96       96              
  Lines       11741    11767      +26     
==========================================
  Hits         5686     5686              
- Misses       5425     5450      +25     
- Partials      630      631       +1     

Files	Coverage Δ
pkg/gcp/actuator/policy.go	68.57% <0.00%> (-0.80%)	⬇️
pkg/gcp/client.go	0.00% <0.00%> (ø)
pkg/gcp/actuator/role.go	56.96% <0.00%> (-3.85%)	⬇️
pkg/gcp/actuator/actuator.go	56.99% <14.28%> (-0.73%)	⬇️
pkg/gcp/mock/client_generated.go	83.85% <0.00%> (-2.42%)	⬇️

[jstuever]

/assign @dlom

[dlom]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dlom, jstuever

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dlom,jstuever]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD c721882 and 2 for PR HEAD a762248 in total

[openshift-ci]

@jstuever: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@jstuever: Jira Issue OCPBUGS-23178: All pull requests linked via external trackers have merged:

• openshift/cloud-credential-operator#637

Jira Issue OCPBUGS-23178 has been moved to the MODIFIED state.

In response to this:

Previously, the GCP sync would error when attempting to add permissions to a custom role that was deleted and pending pruning. This change ensures the custom roles are undeleted.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.