Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.14] OCPBUGS-25275: Azure Workload Identity info in CredsRequests creates a Secret #643

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #587

/assign gallettilance

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 18, 2023

@openshift-cherrypick-robot: [Jira Issue CCO-372](https://issues.redhat.com//browse/CCO-372) has been cloned as [Jira Issue CCO-510](https://issues.redhat.com//browse/CCO-510). Will retitle bug to link to clone.

WARNING: Failed to update the target version for the clone. Please update the target version manually. Full error below:

Full error message. customfield_12319940 - Version name '4.14.z' is not valid: request failed. Please analyze the request body for more details. Status code: 400:
/retitle [release-4.14] [CCO-510](https://issues.redhat.com//browse/CCO-510): Azure Workload Identity info in CredsRequests creates a Secret

In response to this:

This is an automated cherry-pick of #587

/assign gallettilance

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.14] CCO-372: Azure Workload Identity info in CredsRequests creates a Secret [release-4.14] CCO-510: Azure Workload Identity info in CredsRequests creates a Secret Dec 18, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 18, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 18, 2023

@openshift-cherrypick-robot: This pull request references CCO-510 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.14.z" version, but no target version was set.

In response to this:

This is an automated cherry-pick of #587

/assign gallettilance

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (5cd3a77) 48.36% compared to head (d8c1fe4) 48.42%.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           release-4.14     #643      +/-   ##
================================================
+ Coverage         48.36%   48.42%   +0.06%     
================================================
  Files                96       96              
  Lines             11683    11741      +58     
================================================
+ Hits               5650     5686      +36     
- Misses             5407     5425      +18     
- Partials            626      630       +4     
Files Coverage Δ
...redentialsrequest/credentialsrequest_controller.go 48.78% <0.00%> (ø)
pkg/azure/actuator.go 60.97% <69.62%> (+7.27%) ⬆️

... and 2 files with indirect coverage changes

@gallettilance
Copy link
Contributor

/retitle [release-4.14] OCPBUGS-25275: Azure Workload Identity info in CredsRequests creates a Secret

@openshift-ci openshift-ci bot changed the title [release-4.14] CCO-510: Azure Workload Identity info in CredsRequests creates a Secret [release-4.14] [OCPBUGS-25275](https://issues.redhat.com//browse/OCPBUGS-25275): Azure Workload Identity info in CredsRequests creates a Secret Dec 18, 2023
@openshift-ci-robot openshift-ci-robot removed the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 18, 2023
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

This is an automated cherry-pick of #587

/assign gallettilance

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gallettilance
Copy link
Contributor

/retitle [release-4.14] OCPBUGS-25275: Azure Workload Identity info in CredsRequests creates a Secret

@openshift-ci openshift-ci bot changed the title [release-4.14] [OCPBUGS-25275](https://issues.redhat.com//browse/OCPBUGS-25275): Azure Workload Identity info in CredsRequests creates a Secret [release-4.14] OCPBUGS-25275: Azure Workload Identity info in CredsRequests creates a Secret Dec 18, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 18, 2023
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-25275, which is invalid:

  • expected Jira Issue OCPBUGS-25275 to depend on a bug targeting a version in 4.15.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #587

/assign gallettilance

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gallettilance
Copy link
Contributor

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@gallettilance: This pull request references Jira Issue OCPBUGS-25275, which is invalid:

  • expected dependent Jira Issue OCPBUGS-25613 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is New instead
  • expected dependent Jira Issue OCPBUGS-25613 to target a version in 4.15.0, but it targets "4.15" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gallettilance
Copy link
Contributor

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@gallettilance: This pull request references Jira Issue OCPBUGS-25275, which is invalid:

  • expected dependent Jira Issue OCPBUGS-25613 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gallettilance
Copy link
Contributor

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 18, 2023
@openshift-ci-robot
Copy link
Contributor

@gallettilance: This pull request references Jira Issue OCPBUGS-25275, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.z) matches configured target version for branch (4.14.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-25613 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-25613 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0
  • bug has dependents

Requesting review from QA contact:
/cc @jianping-shu

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gallettilance
Copy link
Contributor

/retest

@gallettilance
Copy link
Contributor

/retest

@gallettilance
Copy link
Contributor

/test security
/test e2e-upgrade

@jstuever
Copy link
Contributor

/test e2e-azure

@jstuever
Copy link
Contributor

/test e2e-azure-oidc

Copy link
Contributor

openshift-ci bot commented Dec 18, 2023

@jstuever: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test coverage
  • /test e2e-aws-ovn
  • /test e2e-azure-manual-oidc
  • /test e2e-hypershift
  • /test e2e-upgrade
  • /test images
  • /test periodics-images
  • /test unit
  • /test verify
  • /test verify-deps

The following commands are available to trigger optional jobs:

  • /test e2e-aws-manual-oidc
  • /test e2e-azure
  • /test e2e-azure-upgrade
  • /test e2e-gcp
  • /test e2e-gcp-manual-oidc
  • /test e2e-openstack
  • /test e2e-openstack-parallel
  • /test security

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-cloud-credential-operator-release-4.14-coverage
  • pull-ci-openshift-cloud-credential-operator-release-4.14-e2e-aws-ovn
  • pull-ci-openshift-cloud-credential-operator-release-4.14-e2e-hypershift
  • pull-ci-openshift-cloud-credential-operator-release-4.14-e2e-upgrade
  • pull-ci-openshift-cloud-credential-operator-release-4.14-images
  • pull-ci-openshift-cloud-credential-operator-release-4.14-periodics-images
  • pull-ci-openshift-cloud-credential-operator-release-4.14-security
  • pull-ci-openshift-cloud-credential-operator-release-4.14-unit
  • pull-ci-openshift-cloud-credential-operator-release-4.14-verify
  • pull-ci-openshift-cloud-credential-operator-release-4.14-verify-deps

In response to this:

/test e2e-azure-oidc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jstuever
Copy link
Contributor

/test e2e-aws-manual-oidc

@jstuever
Copy link
Contributor

/test e2e-azure-manual-oidc

@jstuever
Copy link
Contributor

/assign

@jstuever
Copy link
Contributor

/lgtm
/approve
/label backport-risk-assessed

@openshift-ci openshift-ci bot added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. lgtm Indicates that a PR is ready to be merged. labels Dec 18, 2023
Copy link
Contributor

openshift-ci bot commented Dec 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jstuever, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2023
@jstuever
Copy link
Contributor

/override ci/prow/security

Copy link
Contributor

openshift-ci bot commented Dec 18, 2023

@jstuever: Overrode contexts on behalf of jstuever: ci/prow/security

In response to this:

/override ci/prow/security

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

openshift-ci bot commented Dec 18, 2023

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security d8c1fe4 link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jianping-shu
Copy link

Verified with cluster-bot build.
Azure workload Identity cluster installed successfully and OCP-69971 passed.

@jianping-shu
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Dec 20, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit fba5608 into openshift:release-4.14 Dec 20, 2023
14 checks passed
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-25275: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-25275 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #587

/assign gallettilance

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cloud-credential-operator-container-v4.14.0-202312200653.p0.gfba5608.assembly.stream for distgit ose-cloud-credential-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants