Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.14] OCPBUGS-27911: Resolve all outstanding snyk vulnerabilities #650

Merged
merged 2 commits into from Feb 2, 2024

Conversation

dlom
Copy link
Contributor

@dlom dlom commented Jan 10, 2024

xref: CCO-519

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 10, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 10, 2024

@dlom: This pull request references CCO-519 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.14.z" version, but no target version was set.

In response to this:

xref: CCO-519

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dlom
Copy link
Contributor Author

dlom commented Jan 10, 2024

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jan 10, 2024
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2024
@dlom
Copy link
Contributor Author

dlom commented Jan 10, 2024

/assign @jstuever

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fba5608) 48.42% compared to head (d8d96f2) 48.62%.
Report is 8 commits behind head on release-4.14.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           release-4.14     #650      +/-   ##
================================================
+ Coverage         48.42%   48.62%   +0.19%     
================================================
  Files                96       96              
  Lines             11741    11850     +109     
================================================
+ Hits               5686     5762      +76     
- Misses             5425     5459      +34     
+ Partials            630      629       -1     

see 2 files with indirect coverage changes

@jstuever
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2024
Copy link
Contributor

openshift-ci bot commented Jan 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dlom, jstuever

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dlom
Copy link
Contributor Author

dlom commented Jan 24, 2024

/jira cherrypick OCPBUGS-27910

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 24, 2024

@dlom: Jira Issue OCPBUGS-27910 has been cloned as Jira Issue OCPBUGS-27911. Will retitle bug to link to clone.
/retitle OCPBUGS-27911: [release-4.14] CCO-519: Resolve all outstanding snyk vulnerabilities

In response to this:

/jira cherrypick OCPBUGS-27910

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.14] CCO-519: Resolve all outstanding snyk vulnerabilities OCPBUGS-27911: [release-4.14] CCO-519: Resolve all outstanding snyk vulnerabilities Jan 24, 2024
@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jan 24, 2024
@openshift-ci-robot
Copy link
Contributor

@dlom: This pull request references Jira Issue OCPBUGS-27911, which is invalid:

  • expected dependent Jira Issue OCPBUGS-27910 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

xref: CCO-519

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dlom
Copy link
Contributor Author

dlom commented Jan 24, 2024

/retitle [release-4.14] OCPBUGS-27911: Resolve all outstanding snyk vulnerabilities

@openshift-ci openshift-ci bot changed the title OCPBUGS-27911: [release-4.14] CCO-519: Resolve all outstanding snyk vulnerabilities [release-4.14] OCPBUGS-27911: Resolve all outstanding snyk vulnerabilities Jan 24, 2024
@dlom
Copy link
Contributor Author

dlom commented Feb 1, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 1, 2024
@openshift-ci-robot
Copy link
Contributor

@dlom: This pull request references Jira Issue OCPBUGS-27911, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.z) matches configured target version for branch (4.14.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-27910 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-27910 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0
  • bug has dependents

Requesting review from QA contact:
/cc @jianping-shu

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dlom
Copy link
Contributor Author

dlom commented Feb 1, 2024

/label cherry-pick-approved

Copy link
Contributor

openshift-ci bot commented Feb 1, 2024

@dlom: Can not set label cherry-pick-approved: Must be member in one of these teams: []

In response to this:

/label cherry-pick-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jianping-shu
Copy link

Regression tested with cluster-bot build.
AWS cluster installed successfully.
Regression tests OCP-36498/50869/48360/34470 passed.

@jianping-shu
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 2, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD c2d7859 and 2 for PR HEAD d8d96f2 in total

Copy link
Contributor

openshift-ci bot commented Feb 2, 2024

@dlom: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit d63895b into openshift:release-4.14 Feb 2, 2024
11 checks passed
@openshift-ci-robot
Copy link
Contributor

@dlom: Jira Issue OCPBUGS-27911: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-27911 has been moved to the MODIFIED state.

In response to this:

xref: CCO-519

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cloud-credential-operator-container-v4.14.0-202402020610.p0.gd63895b.assembly.stream for distgit ose-cloud-credential-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants