Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCO-454: Bump go.mod k8s deps to 0.29.1 #655

Merged
merged 2 commits into from Jan 19, 2024

Conversation

2uasimojo
Copy link
Member

@2uasimojo 2uasimojo commented Jan 18, 2024

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2024
@2uasimojo
Copy link
Member Author

/assign @dlom

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8bca79f) 48.34% compared to head (7bfe967) 48.34%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #655   +/-   ##
=======================================
  Coverage   48.34%   48.34%           
=======================================
  Files          96       96           
  Lines       11780    11780           
=======================================
  Hits         5695     5695           
  Misses       5452     5452           
  Partials      633      633           

...as well as aux Dockerfiles.

We were already building for ART against 1.21, so this should be safe.

CCO-454
@2uasimojo
Copy link
Member Author

security fail is https://www.cve.org/CVERecord?id=CVE-2019-9514, described in https://issues.redhat.com/browse/OCPBUGS-27382. No fix is available at this time, and it's classified as low severity, so I think it's safe to

/override ci/prow/security

Copy link
Contributor

openshift-ci bot commented Jan 18, 2024

@2uasimojo: Overrode contexts on behalf of 2uasimojo: ci/prow/security

In response to this:

security fail is https://www.cve.org/CVERecord?id=CVE-2019-9514, described in https://issues.redhat.com/browse/OCPBUGS-27382. No fix is available at this time, and it's classified as low severity, so I think it's safe to

/override ci/prow/security

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@2uasimojo 2uasimojo changed the title Bump go.mod k8s deps to 0.29.1 CCO-454: Bump go.mod k8s deps to 0.29.1 Jan 18, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 18, 2024

@2uasimojo: This pull request references CCO-454 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

In response to this:

CCO-454

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 18, 2024
@dlom
Copy link
Contributor

dlom commented Jan 19, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 19, 2024
Copy link
Contributor

openshift-ci bot commented Jan 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 2uasimojo, dlom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dlom
Copy link
Contributor

dlom commented Jan 19, 2024

/override ci/prow/security

Will take a look at this and make a seperate PR

Copy link
Contributor

openshift-ci bot commented Jan 19, 2024

@dlom: Overrode contexts on behalf of dlom: ci/prow/security

In response to this:

/override ci/prow/security

Will take a look at this and make a seperate PR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

openshift-ci bot commented Jan 19, 2024

@2uasimojo: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit f2c6262 into openshift:master Jan 19, 2024
11 checks passed
@2uasimojo 2uasimojo deleted the CCO-454/k8s-1.29 branch January 19, 2024 21:08
@2uasimojo
Copy link
Member Author

Will take a look at this and make a seperate PR

I tried, but there's no fix published yet. I opened https://issues.redhat.com/browse/OCPBUGS-27382 for it.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cloud-credential-operator-container-v4.16.0-202401200231.p0.gf2c6262.assembly.stream for distgit ose-cloud-credential-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants