OCPBUGS-27445: Use cached clients to avoid client side throttling

[fxierh]

Client-side throttling was observed after switching to the live client in the metrics controller in #645.

This PR:

• Adds a (cached) root client to the Calculator struct for querying the root credential only.
• Switches back to the default (cached) client (i.e. mgr.GetClient()) for querying anything else.

[openshift-ci-robot]

@fxierh: This pull request references Jira Issue OCPBUGS-27445, which is invalid:

• expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Client-side throttling was observed after switching to the live client in the metrics controller in #645.

This PR:

• Adds a (cached) root client to the Calculator struct for querying the root credential only.
• Switches back to the default (cached) client (i.e. mgr.GetClient()) for querying anything else.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[fxierh]

/jira refresh

[openshift-ci-robot]

@fxierh: This pull request references Jira Issue OCPBUGS-27445, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jianping-shu

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[fxierh]

/hold

Work in progress.

[codecov]

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (9924b77) 48.34% compared to head (7c4f0b5) 48.34%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #656      +/-   ##
==========================================
- Coverage   48.34%   48.34%   -0.01%     
==========================================
  Files          96       96              
  Lines       11780    11781       +1     
==========================================
  Hits         5695     5695              
- Misses       5452     5453       +1     
  Partials      633      633              

Files	Coverage Δ
pkg/operator/metrics/metrics.go	45.16% <33.33%> (-0.25%)	⬇️

[fxierh]

/unhold

[fxierh]

/assign @jstuever @dlom

Would you please take a look ? Thanks.

[jstuever]

/lgtm
/approve

[jstuever]

/override ci/prow/security

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fxierh, jstuever

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jstuever]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@jstuever: Overrode contexts on behalf of jstuever: ci/prow/security

In response to this:

/override ci/prow/security

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@fxierh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@fxierh: Jira Issue OCPBUGS-27445: All pull requests linked via external trackers have merged:

• openshift/cloud-credential-operator#656

Jira Issue OCPBUGS-27445 has been moved to the MODIFIED state.

In response to this:

Client-side throttling was observed after switching to the live client in the metrics controller in #645.

This PR:

• Adds a (cached) root client to the Calculator struct for querying the root credential only.
• Switches back to the default (cached) client (i.e. mgr.GetClient()) for querying anything else.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jstuever]

/cherry-pick release-4.15

[openshift-cherrypick-robot]

@jstuever: new pull request created: #660

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.