[release-4.14] OCPBUGS-28382: Use cached clients to avoid client side throttling

[openshift-cherrypick-robot]

This is an automated cherry-pick of #660

/assign jstuever

[openshift-ci-robot]

@openshift-cherrypick-robot: Jira Issue OCPBUGS-27901 has been cloned as Jira Issue OCPBUGS-28382. Will retitle bug to link to clone.
/retitle [release-4.14] OCPBUGS-28382: Use cached clients to avoid client side throttling

In response to this:

This is an automated cherry-pick of #660

/assign jstuever

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-28382, which is invalid:

• expected dependent Jira Issue OCPBUGS-27901 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #660

/assign jstuever

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jstuever]

/jira refresh

[openshift-ci-robot]

@jstuever: This pull request references Jira Issue OCPBUGS-28382, which is invalid:

• expected dependent Jira Issue OCPBUGS-27901 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[codecov]

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (3350a1b) 48.42% compared to head (54c552f) 48.41%.

Additional details and impacted files

@@               Coverage Diff                @@
##           release-4.14     #666      +/-   ##
================================================
- Coverage         48.42%   48.41%   -0.01%     
================================================
  Files                96       96              
  Lines             11743    11744       +1     
================================================
  Hits               5686     5686              
- Misses             5426     5427       +1     
  Partials            631      631              

Files	Coverage Δ
pkg/operator/metrics/metrics.go	45.16% <33.33%> (-0.25%)	⬇️

[jianping-shu]

/retest-required

[jianping-shu]

Verified with cluster-bot build.
AWS cluster installed successfully.
Changed cco log level to Debug.
CCO metrics cco_credentials_mode, cco_credentials_requests etc reported correctly.
Checked no more 'throttling' in cco log.

[jianping-shu]

/label cherry-pick-approved

[jstuever]

/lgtm
/approve

[jstuever]

/label backport-risk-assessed

[jstuever]

/override ci/prow/security

[jstuever]

/jira refresh

[openshift-ci-robot]

@jstuever: This pull request references Jira Issue OCPBUGS-28382, which is valid.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.z) matches configured target version for branch (4.14.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
• dependent bug Jira Issue OCPBUGS-27901 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-27901 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0
• bug has dependents

Requesting review from QA contact:
/cc @jianping-shu

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jstuever, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jstuever]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@jstuever: Overrode contexts on behalf of jstuever: ci/prow/security

In response to this:

/override ci/prow/security

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@openshift-cherrypick-robot: Jira Issue OCPBUGS-28382: All pull requests linked via external trackers have merged:

• openshift/cloud-credential-operator#666

Jira Issue OCPBUGS-28382 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #660

/assign jstuever

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cloud-credential-operator-container-v4.14.0-202401301910.p0.gc2d7859.assembly.stream for distgit ose-cloud-credential-operator.
All builds following this will include this PR.