Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AUTH-482: set required-scc for openshift workloads #681

Merged
merged 1 commit into from Apr 1, 2024

Conversation

liouk
Copy link
Member

@liouk liouk commented Feb 20, 2024

No description provided.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 20, 2024

@liouk: This pull request references AUTH-482 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 20, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 20, 2024
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.21%. Comparing base (5b3a050) to head (1355336).
Report is 28 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #681      +/-   ##
==========================================
+ Coverage   48.42%   49.21%   +0.79%     
==========================================
  Files          96       96              
  Lines       11776    12105     +329     
==========================================
+ Hits         5702     5958     +256     
- Misses       5442     5510      +68     
- Partials      632      637       +5     
Files Coverage Δ
pkg/assets/v410_00_assets/bindata.go 46.96% <ø> (ø)

... and 4 files with indirect coverage changes

@liouk liouk changed the title WIP: AUTH-482: set required-scc for openshift workloads AUTH-482: set required-scc for openshift workloads Feb 22, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 22, 2024
@liouk liouk changed the title AUTH-482: set required-scc for openshift workloads WIP: AUTH-482: set required-scc for openshift workloads Feb 22, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 22, 2024
@jstuever
Copy link
Contributor

/retest-required

@liouk liouk changed the title WIP: AUTH-482: set required-scc for openshift workloads AUTH-482: set required-scc for openshift workloads Mar 20, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 20, 2024
@jstuever
Copy link
Contributor

/cc

@openshift-ci openshift-ci bot requested a review from jstuever March 27, 2024 21:56
Copy link
Contributor

@jstuever jstuever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 1, 2024
Copy link
Contributor

openshift-ci bot commented Apr 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jstuever, liouk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 1, 2024
Copy link
Contributor

openshift-ci bot commented Apr 1, 2024

@liouk: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit e1b51b1 into openshift:master Apr 1, 2024
11 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cloud-credential-operator-container-v4.16.0-202404020548.p0.ge1b51b1.assembly.stream.el8 for distgit ose-cloud-credential-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants