New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-30478: Update to cloud.google.com/go/storage v1.39.1 #688
Conversation
Update cloud.google.com/go/storage module in order to indirectly update update google.golang.org/protobuf
@jstuever: This pull request references Jira Issue OCPBUGS-30478, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #688 +/- ##
==========================================
+ Coverage 48.37% 48.56% +0.19%
==========================================
Files 96 96
Lines 11792 11912 +120
==========================================
+ Hits 5704 5785 +81
- Misses 5455 5490 +35
- Partials 633 637 +4 |
Verified with cluster-bot build. |
/cherry-pick release-4.15 |
@jstuever: once the present PR merges, I will cherry-pick it on top of release-4.15 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jstuever, lleshchi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/label acknowledge-critical-fixes-only |
@jstuever: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@jstuever: Jira Issue OCPBUGS-30478: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-30478 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@jstuever: #688 failed to apply on top of branch "release-4.15":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[ART PR BUILD NOTIFIER] This PR has been included in build ose-cloud-credential-operator-container-v4.16.0-202403180813.p0.g9bad012.assembly.stream.el8 for distgit ose-cloud-credential-operator. |
Update cloud.google.com/go/storage module in order to indirectly update update google.golang.org/protobuf