OCPBUGS-31290: Dockerfile should keep prior rhel8 behavior for ccoctl default

[jstuever]

Previously we updated the Dockerfile to default to RHEL9 ccoctl binary. However, in order to remain consistent with prior behavior, we should instead default to the RHEL8 binary.

[openshift-ci-robot]

@jstuever: This pull request references Jira Issue OCPBUGS-31290, which is invalid:

• expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Previously we updated the Dockerfile to default to RHEL9 ccoctl binary. However, in order to remain consistent with prior behavior, we should instead default to the RHEL8 binary.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jstuever]

/test e2e-aws-manual-oidc e2e-azure-manual-oidc e2e-gcp-manual-oidc

[jstuever]

/jira refresh
/override ci/prow/security

[openshift-ci-robot]

@jstuever: This pull request references Jira Issue OCPBUGS-31290, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jianping-shu

In response to this:

/jira refresh
/override ci/prow/security

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@jstuever: Overrode contexts on behalf of jstuever: ci/prow/security

In response to this:

/jira refresh
/override ci/prow/security

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@jstuever: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[jianping-shu]

Verified with cluster-bot build and AWS STS flexy template.
ccoctl ran on rhel8 agent and AWS STS cluster installed successfully.

https://mastern-jenkins-csb-openshift-qe.apps.ocp-c1.prod.psi.redhat.com/job/ocp-common/job/Flexy-install/278060/consoleFull
04-22 08:41:37.362 Running Command: ./ccoctl aws create-all --name='jshu22-22582' --region='us-east-2' --credentials-requests-dir='/home/jenkins/ws/workspace/ocp-common/Flexy-install/flexy/workdir/install-dir/pre_action/sts/creds' --output-dir '/home/jenkins/ws/workspace/ocp-common/Flexy-install/flexy/workdir/install-dir/pre_action/sts' 04-22 08:41:37.363 2024/04/22 00:41:36 Generating RSA keypair 04-22 08:41:39.250 2024/04/22 00:41:38 Writing private key to /home/jenkins/ws/workspace/ocp-common/Flexy-install/flexy/workdir/install-dir/pre_action/sts/serviceaccount-signer.private

[joepvd]

Hmm this basically makes a rhel8 compiled ccoctl running in a rhel9 container. I think this does not give runtime errors, but should not be intended.

[jstuever]

Hmm this basically makes a rhel8 compiled ccoctl running in a rhel9 container. I think this does not give runtime errors, but should not be intended.

ccoctl does not run in cluster, it is intended to be downloaded by the end user and executed on their workstation.

[jstuever]

/assign @dlom
We may also need to update the CI jobs to pick the right binary based on the container.

[dlom]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dlom, jstuever

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dlom,jstuever]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@jstuever: Jira Issue OCPBUGS-31290: All pull requests linked via external trackers have merged:

• openshift/cloud-credential-operator#693
• openshift/cloud-credential-operator#692
• openshift/cloud-credential-operator#694

Jira Issue OCPBUGS-31290 has been moved to the MODIFIED state.

In response to this:

Previously we updated the Dockerfile to default to RHEL9 ccoctl binary. However, in order to remain consistent with prior behavior, we should instead default to the RHEL8 binary.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cloud-credential-operator-container-v4.16.0-202404222343.p0.g6fe4910.assembly.stream.el9 for distgit ose-cloud-credential-operator.
All builds following this will include this PR.