[release-4.12] OCPBUGS-13802: sync CloudPrivateIpConfig when node is missing

[jluhrsen]

in the case that an egressIP is assigned to a node and that node is deleted, the sync will not be able to Get() that node but we still need to release
that IP and be able assign that to another node
in the egressIP object. The machine must be deleted as well, although that should be what triggers
the node delete.

[openshift-ci]

@jluhrsen: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

sync CloudPrivateIpConfig when node is missing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@jluhrsen: This pull request references Jira Issue OCPBUGS-13802, which is invalid:

• expected the bug to target the "4.12.z" version, but it targets "4.13.0" instead
• expected Jira Issue OCPBUGS-13802 to depend on a bug targeting a version in 4.13.0, 4.13.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

in the case that an egressIP is assigned to a node and that node is deleted, the sync will not be able to Get() that node but we still need to release
that IP and be able assign that to another node
in the egressIP object. The machine must be deleted as well, although that should be what triggers
the node delete.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@jluhrsen: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

OCPBUGS-13802: sync CloudPrivateIpConfig when node is missing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jluhrsen]

/jira refresh

[openshift-ci-robot]

@jluhrsen: This pull request references Jira Issue OCPBUGS-13802, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.12.z) matches configured target version for branch (4.12.z)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
• dependent bug Jira Issue OCPBUGS-13127 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
• dependent Jira Issue OCPBUGS-13127 targets the "4.13.0" version, which is one of the valid target versions: 4.13.0, 4.13.z
• bug has dependents

Requesting review from QA contact:
/cc @huiran0826

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jluhrsen]

I have tested this locally and verified it works as expected.

[kyrtapz]

@jluhrsen unit tests are failing :(
When there are conflicts during backports it is good to mention them in the commit/pr description. It allows reviewers to focus on those areas.

Additionally, when doing a manual backport please use git cherry-pick -x ... so it preserves where the cherry-pick came from

/retitle [release-4.12] OCPBUGS-13802: sync CloudPrivateIpConfig when node is missing

[openshift-ci]

@jluhrsen: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Retaining the bugzilla/valid-bug label as it was manually added.

In response to this:

[release-4.12] OCPBUGS-13802: sync CloudPrivateIpConfig when node is missing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jluhrsen]

/retest

[jluhrsen]

retest

[jluhrsen]

/retest

[openshift-ci]

@jluhrsen: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[jluhrsen]

@jluhrsen unit tests are failing :( When there are conflicts during backports it is good to mention them in the commit/pr description. It allows reviewers to focus on those areas.

Additionally, when doing a manual backport please use git cherry-pick -x ... so it preserves where the cherry-pick came from

/retitle [release-4.12] OCPBUGS-13802: sync CloudPrivateIpConfig when node is missing

well, I wasn't in "cherry-pick" mode because I didn't do an actual "git cherry-pick" and just manually made
the changes. The conflicts when doing the cherry-pick were too confusing to fix compared to just grabbing
the changes manually and putting them in the right place.

sorry.

oh, and the unit tests are now passing. not sure why they were failing originally. they pass locally too.

[kyrtapz]

/lgtm
/label backport-risk-assessed

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jluhrsen, kyrtapz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [kyrtapz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[huiran0826]

/label cherry-pick-approved

[openshift-ci-robot]

@jluhrsen: Jira Issue OCPBUGS-13802: All pull requests linked via external trackers have merged:

• openshift/cloud-network-config-controller#112

Jira Issue OCPBUGS-13802 has been moved to the MODIFIED state.

In response to this:

in the case that an egressIP is assigned to a node and that node is deleted, the sync will not be able to Get() that node but we still need to release
that IP and be able assign that to another node
in the egressIP object. The machine must be deleted as well, although that should be what triggers
the node delete.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-merge-robot]

Fix included in accepted release 4.12.0-0.nightly-2023-06-02-025852