Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.14] OCPBUGS-21785: Azure: skip backend pool if attached to an outbound rule #125

Merged
merged 1 commit into from Oct 23, 2023
Merged

[release-4.14] OCPBUGS-21785: Azure: skip backend pool if attached to an outbound rule #125

merged 1 commit into from Oct 23, 2023

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #121

/assign ricky-rav

@ricky-rav
Azure: skip backend pool if attached to an outbound rule
e95a6ff 
When configuring egress IP on Azure, omit the backend address pool if it's attached to an outbound rule, since attaching a secondary IP is not allowed in such cases on Azure, resulting in an OutboundRuleCannotBeUsedWithBackendAddressPoolThatIsReferencedBySecondaryIpConfigs error.

This affects the following setups:
- azure private clusters
- aro private clusters
- aro public custers

WARNING: as a result, the egress IP will have no outbound connectivity except to the infrastructure subnet. Further investigation is needed to let the egress IP communicate to the outside.

Signed-off-by: Riccardo Ravaioli <rravaiol@redhat.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 17, 2023
Merged
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-5491 has been cloned as Jira Issue OCPBUGS-21785. Will retitle bug to link to clone.
/retitle [release-4.14] OCPBUGS-21785: Azure: skip backend pool if attached to an outbound rule

In response to this:

This is an automated cherry-pick of #121

/assign ricky-rav

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.14] OCPBUGS-5491: Azure: skip backend pool if attached to an outbound rule [release-4.14] OCPBUGS-21785: Azure: skip backend pool if attached to an outbound rule Oct 17, 2023
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Oct 17, 2023
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-21785, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-5491 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-5491 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0
  • bug has dependents

Requesting review from QA contact:
/cc @anuragthehatter

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #121

/assign ricky-rav

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ricky-rav
Copy link
Contributor

/retest

@flavio-fernandes
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 17, 2023

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@trozet
Copy link
Contributor

trozet commented Oct 23, 2023

/label backport-risk-assessed

@trozet
Copy link
Contributor

trozet commented Oct 23, 2023

/approve

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Oct 23, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flavio-fernandes, openshift-cherrypick-robot, trozet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2023
@jechen0648
Copy link

/label cherry-pick-approved

@knobunc knobunc added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead). labels Oct 23, 2023
@openshift-ci openshift-ci bot merged commit 9cb1bbd into openshift:release-4.14 Oct 23, 2023
10 checks passed
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-21785: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-21785 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #121

/assign ricky-rav

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.14.0-0.nightly-2023-10-23-223425

@ricky-rav
Copy link
Contributor

/cherry-pick release-4.13

@openshift-cherrypick-robot
Copy link
Author

@ricky-rav: #125 failed to apply on top of branch "release-4.13":

Applying: Azure: skip backend pool if attached to an outbound rule
Using index info to reconstruct a base tree...
M	pkg/cloudprovider/azure.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/cloudprovider/azure.go
CONFLICT (content): Merge conflict in pkg/cloudprovider/azure.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Azure: skip backend pool if attached to an outbound rule
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ricky-rav
Copy link
Contributor

/jira-cherry-pick release-4.13

@ricky-rav ricky-rav mentioned this pull request Oct 24, 2023
Merged
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cloud-network-config-controller-container-v4.14.0-202311211133.p0.g9cb1bbd.assembly.stream for distgit ose-cloud-network-config-controller.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anuragthehatter anuragthehatter Awaiting requested review from anuragthehatter

@abhat abhat Awaiting requested review from abhat

@andreaskaris andreaskaris Awaiting requested review from andreaskaris

Assignees

@ricky-rav ricky-rav

@mffiedler mffiedler

@rbbratta rbbratta

@flavio-fernandes flavio-fernandes

@weliang1 weliang1

@anuragthehatter anuragthehatter

@huiran0826 huiran0826

@asood-rh asood-rh

@jechen0648 jechen0648

@qiowang721 qiowang721

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet