OCPBUGS-33154: Incorrect use of go wait groups

[squirrd]

Minor change to the wait group to ensure the controller does not hang.

The wg.Add(1) (line 198) should be moved closer to the function it is waiting for (line 226).

Having a function (that could exit) between wg.add() and the function with the matching wg.done() could lead to a state where the controller hangs, waiting for the wg.done() that is never called.

[openshift-ci-robot]

@squirrd: This pull request references Jira Issue OCPBUGS-33154, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @anuragthehatter

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Minor change to the wait group to ensure the controller does not hang.

The wg.Add(1) (line 198) should be moved closer to the function it is waiting for (line 226).

Having a function (that could exit) between wg.add() and the function with the matching wg.done() could lead to a state where the controller hangs, waiting for the wg.done() that is never called.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[martinkennelly]

/test e2e-azure-ovn

Unrelated.

[openshift-ci]

@squirrd: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/security	aeab4d8	link	false	/test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[martinkennelly]

/test e2e-azure-ovn

cluster init failure

[kyrtapz]

/lgtm
Thanks @squirrd!

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kyrtapz, martinkennelly, squirrd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [kyrtapz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@squirrd: Jira Issue OCPBUGS-33154: All pull requests linked via external trackers have merged:

• openshift/cloud-network-config-controller#140

Jira Issue OCPBUGS-33154 has been moved to the MODIFIED state.

In response to this:

Minor change to the wait group to ensure the controller does not hang.

The wg.Add(1) (line 198) should be moved closer to the function it is waiting for (line 226).

Having a function (that could exit) between wg.add() and the function with the matching wg.done() could lead to a state where the controller hangs, waiting for the wg.done() that is never called.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cloud-network-config-controller-container-v4.16.0-202405060852.p0.g43c7556.assembly.stream.el9 for distgit ose-cloud-network-config-controller.
All builds following this will include this PR.

[openshift-merge-robot]

Fix included in accepted release 4.16.0-0.nightly-2024-05-07-025557