Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.11] OCPBUGS-4528: AWS: build temp credentials file from AWS key and secret #84

Merged
merged 1 commit into from Dec 7, 2022
Merged

[release-4.11] OCPBUGS-4528: AWS: build temp credentials file from AWS key and secret #84

merged 1 commit into from Dec 7, 2022

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #68

/assign kyrtapz

@andreaskaris
AWS: build temp credentials file from AWS key and secret
5b83a02 
If file credentials cannot be found then build a temp file from
aws_access_key_id and aws_secret_access_key.
Other operators build AWS credentials from aws_access_key_id and
aws_secret_access_key without the need to have an explicit credentials
file. This is not a problem for environments where the
cloud-credential-operator injects the correct data. However, in manual
credentials mode, users seem to expect to only provide the key_id and
access_key.

Reported-at: https://issues.redhat.com/browse/OCPBUGS-1417
Signed-off-by: Andreas Karis <ak.karis@gmail.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 6, 2022
Merged
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-1417 has been cloned as Jira Issue OCPBUGS-4528. Retitling PR to link against new bug.
/retitle [release-4.11] OCPBUGS-4528: AWS: build temp credentials file from AWS key and secret

In response to this:

This is an automated cherry-pick of #68

/assign kyrtapz

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.11] OCPBUGS-1417: AWS: build temp credentials file from AWS key and secret [release-4.11] OCPBUGS-4528: AWS: build temp credentials file from AWS key and secret Dec 6, 2022
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Dec 6, 2022
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-4528, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.11.z) matches configured target version for branch (4.11.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-1417 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-1417 targets the "4.12.0" version, which is one of the valid target versions: 4.12.0
  • bug has dependents

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #68

/assign kyrtapz

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 6, 2022

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.11] OCPBUGS-4528: AWS: build temp credentials file from AWS key and secret

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@andreaskaris
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2022
@kyrtapz
Copy link
Contributor

kyrtapz commented Dec 6, 2022

/approve
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Dec 6, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 6, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreaskaris, kyrtapz, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2022
@kyrtapz
Copy link
Contributor

kyrtapz commented Dec 6, 2022

/retest

1 similar comment
@kyrtapz
Copy link
Contributor

kyrtapz commented Dec 7, 2022

/retest

@huiran0826
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Dec 7, 2022
@openshift-merge-robot openshift-merge-robot merged commit 7876bc6 into openshift:release-4.11 Dec 7, 2022
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-4528 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #68

/assign kyrtapz

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jluhrsen jluhrsen Awaiting requested review from jluhrsen

@trozet trozet Awaiting requested review from trozet

Assignees

@mffiedler mffiedler

@rbbratta rbbratta

@andreaskaris andreaskaris

@weliang1 weliang1

@kyrtapz kyrtapz

@anuragthehatter anuragthehatter

@huiran0826 huiran0826

@asood-rh asood-rh

@jechen0648 jechen0648

@qiowang721 qiowang721

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet