Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-23004: Merge https://github.com/kubernetes/cloud-provider-alibaba-cloud:master (8244569) into master #37

Merged

Conversation

cloud-team-rebase-bot[bot]
Copy link

No description provided.

gujingit and others added 30 commits August 1, 2023 15:03
feat: filter pods whose ip not in vpc cidr in eni mod
feat: update instanceChargeType && instanceSpec
support configuring server group batch size
…controller-test

test: update route controller tests
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Nov 7, 2023
@openshift-ci-robot
Copy link

@cloud-team-rebase-bot[bot]: This pull request references Jira Issue OCPBUGS-23004, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @miyadav

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

cloud-team-rebase-bot and others added 11 commits December 21, 2023 13:05
# Conflicts:
#	vendor/golang.org/x/sys/execabs/execabs_go118.go
#	vendor/golang.org/x/sys/execabs/execabs_go119.go
#	vendor/golang.org/x/text/width/tables10.0.0.go
#	vendor/golang.org/x/text/width/tables11.0.0.go
#	vendor/golang.org/x/text/width/tables12.0.0.go
#	vendor/golang.org/x/text/width/tables13.0.0.go
#	vendor/golang.org/x/text/width/tables9.0.0.go
Copy link

openshift-ci bot commented Dec 21, 2023

@cloud-team-rebase-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-alibabacloud a430a61 link false /test e2e-alibabacloud

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JoelSpeed
Copy link

/approve
/lgtm
/override ci/prow/lint

Overriding the linter since it is only a warning about deprecated code. We aren't shipping Alibaba in 4.16 but we will need to backport this change, so making sure it makes it to master.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 11, 2024
Copy link

openshift-ci bot commented Jan 11, 2024

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/lint

In response to this:

/approve
/lgtm
/override ci/prow/lint

Overriding the linter since it is only a warning about deprecated code. We aren't shipping Alibaba in 4.16 but we will need to backport this change, so making sure it makes it to master.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

openshift-ci bot commented Jan 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 97e8335 into openshift:master Jan 11, 2024
6 of 7 checks passed
@openshift-ci-robot
Copy link

@cloud-team-rebase-bot[bot]: Jira Issue OCPBUGS-23004: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-23004 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-alibaba-cloud-controller-manager-container-v4.16.0-202401111849.p0.g97e8335.assembly.stream for distgit ose-alibaba-cloud-controller-manager.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants