OCPBUGS-8213: Ensure removal of security group rules on deleting load balancers #57
Conversation
JoelSpeed
changed the title
|
/label qe-approved |
openshift-ci
bot
added
the
qe-approved
|
/jira refresh |
|
@JoelSpeed: Jira Issue OCPBUGS-8213 is in a security level that is not in the allowed security levels for this repo.
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
JoelSpeed
force-pushed
the
remove-sg-rules-untagged-groups-openshift
branch
from
dcce22c
to
d0cd815
Compare
|
@JoelSpeed - will this merge any time soon? |
Ditto? |
|
Still not getting any response upstream about the fix, will discuss with the team about merging it in the absence of upstream attention |
|
just commenting here, i'm happy to bring this up with the sig again, but i feel that @JoelSpeed has done the due diligence on this patch and i would be comfortable carrying it. hopefully we can get upstream to accept it at some point. |
JoelSpeed
added
jira/valid-bug
|
Manually adding the jira labels since the bug report is restricted and not public |
There was a problem hiding this comment.
this is complex stuff, thanks for the fix @JoelSpeed
/approve
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elmiko The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@JoelSpeed: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-aws-cloud-controller-manager-container-v4.16.0-202405100946.p0.g84c92c1.assembly.stream.el9 for distgit ose-aws-cloud-controller-manager. |
When the security group that an instance belongs to is not tagged with the cluster tag, the CCM will happily add a rule from the instance security group to allow traffic from the load balancer security group. However, when it comes to removing the load balancer, if it is intending to remove the security group, it currently does not take into account unmanaged groups where it must still remove the rules to allow the security group to be removed.
More details in the upstream PR and linked issue.