OCPBUGS-22598, OCPCLOUD-2421: Merge https://github.com/kubernetes/cloud-provider-gcp:master (58ec6ae) into master #53
Conversation
![cloud-team-rebase-bot[bot]](https://avatars.githubusercontent.com/u/74064623?s=60&v=4){kind=small}
Change-Id: I6a562aae3fae34b8fd22a2043107d96bf4df38c2
Change-Id: I32f47f6c09512aa090829ee72497c507e82c90bf
Update to go1.20.12
openshift-ci
bot
added
the
needs-ok-to-test
|
Hi @cloud-team-rebase-bot[bot]. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…t with Multi Networking Depends on whether the node has label for subnet and Pod range: - if no label, node ipam controller keeps the old way to compare default GNP and Network to get the default CIDRs - if label exists, node ipam controller use the labels to get the default CIDRs also revert change in pull#607
This reverts commit ce1a81a.
Update Node pod CIDR in ipam controller for for Multi Pod CIDR suppor…
Change-Id: Iddfd5a8cf9bd5a9103eed9a29330ffebeb139c1c
Change-Id: I3bbe9e38bfe7962a774f2d10ea9dd552b12cbe03
Change-Id: Ic34b18f58ac566758995edbd4f14bdd34e0d2b23
Fix typo in README
Kubernetes 1.29
cloud-team-rebase-bot
bot
changed the title
cloud-team-bot
bot
force-pushed
the
rebase-bot-master
branch
from
07cdcf7
to
5c006eb
Compare
…d Network - GNP controller reads the new pod ranges from node label for default Paramset - If the pod range is not part of the default Paramset, GNP controller updates the default Paramset with the new ranges and marks default Network notReady
Add syncDefaultPodRanges change for Multi-networking default Param an…
…ed by Ingress-GCE (cherry picked from commit 97e991b)
Based on docs for internal loadbalancer here [1], backend services [2] and instances in instance-groups [3], following restrictions apply: - Internal LB can load balance to VMs in same region, but different subnets - Instance groups for the backend service must contain instance of the same subnet - An instance can only belong to one load balanced instance group - It is probably useful use-case to have nodes for the cluster belong to more than one subnet. And the current setup fails to create an internal load balancer with nodes in multiple subnets. This change finds pre-existing instance-groups that ONLY contain instances that belong to the cluster, uses them for the backend service. And only ensures instance-groups for remaining ones. [1] https://cloud.google.com/load-balancing/docs/internal [2] https://cloud.google.com/load-balancing/docs/backend-service#restrictions_and_guidance [3] https://cloud.google.com/compute/docs/instance-groups/creating-groups-of-unmanaged-instances#addinstances Co-authored-by: Abhinav Dahiya <abhinav.dahiya@redhat.com> Signed-off-by: Nolan Brubaker <nolan@nbrubaker.com> # Conflicts: # vendor/k8s.io/cloud-provider-gcp/providers/gce/gce.go # vendor/k8s.io/cloud-provider-gcp/providers/gce/gce_fake.go # vendor/k8s.io/cloud-provider-gcp/providers/gce/gce_instancegroup.go # vendor/k8s.io/cloud-provider-gcp/providers/gce/gce_loadbalancer_internal.go
…r image to be consistent with ART Reconciling with https://github.com/openshift/ocp-build-data/tree/9dc2a375bf335e7e4e3d7e75abc5c3bdbb0c0e98/images/ose-gcp-cloud-controller-manager.yml
…r image to be consistent with ART Reconciling with https://github.com/openshift/ocp-build-data/tree/e5df10e41b14c724468c8f78e2690f219279bfc4/images/ose-gcp-cloud-controller-manager.yml
…r image to be consistent with ART Reconciling with https://github.com/openshift/ocp-build-data/tree/4022cd290f00a44d667dda03f2d78d84a488c7ed/images/ose-gcp-cloud-controller-manager.yml
cloud-team-rebase-bot
bot
changed the title
cloud-team-bot
bot
force-pushed
the
rebase-bot-master
branch
from
5c006eb
to
3c9f4ce
Compare
|
/ok-to-test |
openshift-ci
bot
added
ok-to-test
|
@cloud-team-rebase-bot[bot]: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retitle OCPBUGS-22598: Merge https://github.com/kubernetes/cloud-provider-gcp:master (58ec6ae) into master |
openshift-ci
bot
changed the title
openshift-ci-robot
added
jira/valid-reference
|
@cloud-team-rebase-bot[bot]: This pull request references Jira Issue OCPBUGS-22598, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@theobarberbany: This pull request references Jira Issue OCPBUGS-22598, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@cloud-team-rebase-bot[bot]: Jira Issue OCPBUGS-22598: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-22598 has been moved to the MODIFIED state. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
JoelSpeed
changed the title
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-gcp-cloud-controller-manager-container-v4.16.0-202401081411.p0.gc4b5d37.assembly.stream for distgit ose-gcp-cloud-controller-manager. |
No description provided.