New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPCLOUD-2463: Adds auth-provider-gcp .spec file and build script #58
OCPCLOUD-2463: Adds auth-provider-gcp .spec file and build script #58
Conversation
1c558e4
to
82f068e
Compare
@theobarberbany: This pull request references OCPCLOUD-2463 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@theobarberbany: This pull request references OCPCLOUD-2463 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
82f068e
to
8d1523b
Compare
/retest |
CI failures are unrelated. We're adding a file that's not executed. 😕 |
8d1523b
to
90f4780
Compare
This adds the .spec required for building auth-provider-gcp as an RPM To keep naming consistent across credential provider specs, we use the name gcr-credential-provider It also includes build-rpms.sh, used to build the RPM in CI.
90f4780
to
8f00aea
Compare
@theobarberbany: This pull request references OCPCLOUD-2463 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@theobarberbany: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This is verified as building in CI: [root@af7ae491f208 /]# rpm -Uvh gcr-credential-provider-4.16.0-20240207T165423Z.el9.x86_64.rpm
Verifying... ################################# [100%]
Preparing... ################################# [100%]
Updating / installing...
1:gcr-credential-provider-4.16.0-20################################# [100%] [root@af7ae491f208 /]# /usr/libexec/kubelet-image-credential-provider-plugins/gcr-credential-provider
GCP CRI authentication plugin
Usage:
auth-provider-gcp [command]
Available Commands:
completion Generate the autocompletion script for the specified shell
get-credentials Get authentication credentials
help Help about any command
Flags:
--add_dir_header If true, adds the file directory to the header of the log messages
--alsologtostderr log to standard error as well as files (no effect when -logtostderr=true)
-h, --help help for auth-provider-gcp
--log_backtrace_at traceLocation when logging hits line file:N, emit a stack trace (default :0)
--log_dir string If non-empty, write log files in this directory (no effect when -logtostderr=true)
--log_file string If non-empty, use this log file (no effect when -logtostderr=true)
--log_file_max_size uint Defines the maximum size a log file can grow to (no effect when -logtostderr=true). Unit is megabytes. If the value is 0, the maximum file size is unlimited. (default 1800)
--logtostderr log to standard error instead of files (default true)
--one_output If true, only write logs to their native severity level (vs also writing to each lower severity level; no effect when -logtostderr=true)
--skip_headers If true, avoid header prefixes in the log messages
--skip_log_headers If true, avoid headers when opening log files (no effect when -logtostderr=true)
--stderrthreshold severity logs at or above this threshold go to stderr when writing to files and stderr (no effect when -logtostderr=true or -alsologtostderr=true) (default 2)
-v, --v Level number for the log level verbosity
--vmodule moduleSpec comma-separated list of pattern=N settings for file-filtered logging
Use "auth-provider-gcp [command] --help" for more information about a command. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[ART PR BUILD NOTIFIER] This PR has been included in build ose-gcp-cloud-controller-manager-container-v4.16.0-202402090109.p0.g26b43df.assembly.stream.el9 for distgit ose-gcp-cloud-controller-manager. |
/cherry-pick release-4.15 |
@theobarberbany: new pull request created: #59 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This adds the .spec required for building auth-provider-gcp as an RPM
To keep naming consistent across credential provider specs, we use the
name gcr-credential-provider
It also includes build-rpms.sh, used to build the RPM in CI.