Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPCLOUD-2463: Adds auth-provider-gcp .spec file and build script #58

Merged
merged 1 commit into from Feb 8, 2024

Conversation

theobarberbany
Copy link

@theobarberbany theobarberbany commented Feb 5, 2024

This adds the .spec required for building auth-provider-gcp as an RPM

To keep naming consistent across credential provider specs, we use the
name gcr-credential-provider

It also includes build-rpms.sh, used to build the RPM in CI.

@theobarberbany theobarberbany force-pushed the adds-specfile branch 2 times, most recently from 1c558e4 to 82f068e Compare February 5, 2024 10:30
@theobarberbany theobarberbany changed the title Adds auth-provider-gcp .spec file OCPCLOUD-2463: Adds auth-provider-gcp .spec file Feb 5, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 5, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 5, 2024

@theobarberbany: This pull request references OCPCLOUD-2463 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

This adds the .spec required for building auth-provider-gcp as an RPM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@theobarberbany
Copy link
Author

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 5, 2024

@theobarberbany: This pull request references OCPCLOUD-2463 which is a valid jira issue.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@theobarberbany
Copy link
Author

/retest

@theobarberbany
Copy link
Author

CI failures are unrelated. We're adding a file that's not executed. 😕

This adds the .spec required for building auth-provider-gcp as an RPM

To keep naming consistent across credential provider specs, we use the
name gcr-credential-provider

It also includes build-rpms.sh, used to build the RPM in CI.
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 7, 2024

@theobarberbany: This pull request references OCPCLOUD-2463 which is a valid jira issue.

In response to this:

This adds the .spec required for building auth-provider-gcp as an RPM

To keep naming consistent across credential provider specs, we use the
name gcr-credential-provider

It also includes build-rpms.sh, used to build the RPM in CI.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@theobarberbany theobarberbany changed the title OCPCLOUD-2463: Adds auth-provider-gcp .spec file OCPCLOUD-2463: Adds auth-provider-gcp .spec file and build script Feb 7, 2024
Copy link

openshift-ci bot commented Feb 7, 2024

@theobarberbany: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@theobarberbany
Copy link
Author

This is verified as building in CI:

[root@af7ae491f208 /]# rpm -Uvh gcr-credential-provider-4.16.0-20240207T165423Z.el9.x86_64.rpm
Verifying...                          ################################# [100%]
Preparing...                          ################################# [100%]
Updating / installing...
   1:gcr-credential-provider-4.16.0-20################################# [100%]
[root@af7ae491f208 /]# /usr/libexec/kubelet-image-credential-provider-plugins/gcr-credential-provider
GCP CRI authentication plugin

Usage:
  auth-provider-gcp [command]

Available Commands:
  completion      Generate the autocompletion script for the specified shell
  get-credentials Get authentication credentials
  help            Help about any command

Flags:
      --add_dir_header                   If true, adds the file directory to the header of the log messages
      --alsologtostderr                  log to standard error as well as files (no effect when -logtostderr=true)
  -h, --help                             help for auth-provider-gcp
      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
      --log_dir string                   If non-empty, write log files in this directory (no effect when -logtostderr=true)
      --log_file string                  If non-empty, use this log file (no effect when -logtostderr=true)
      --log_file_max_size uint           Defines the maximum size a log file can grow to (no effect when -logtostderr=true). Unit is megabytes. If the value is 0, the maximum file size is unlimited. (default 1800)
      --logtostderr                      log to standard error instead of files (default true)
      --one_output                       If true, only write logs to their native severity level (vs also writing to each lower severity level; no effect when -logtostderr=true)
      --skip_headers                     If true, avoid header prefixes in the log messages
      --skip_log_headers                 If true, avoid headers when opening log files (no effect when -logtostderr=true)
      --stderrthreshold severity         logs at or above this threshold go to stderr when writing to files and stderr (no effect when -logtostderr=true or -alsologtostderr=true) (default 2)
  -v, --v Level                          number for the log level verbosity
      --vmodule moduleSpec               comma-separated list of pattern=N settings for file-filtered logging

Use "auth-provider-gcp [command] --help" for more information about a command.

@JoelSpeed
Copy link

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 8, 2024
Copy link

openshift-ci bot commented Feb 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 26b43df into openshift:master Feb 8, 2024
8 checks passed
@theobarberbany theobarberbany deleted the adds-specfile branch February 8, 2024 12:24
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-gcp-cloud-controller-manager-container-v4.16.0-202402090109.p0.g26b43df.assembly.stream.el9 for distgit ose-gcp-cloud-controller-manager.
All builds following this will include this PR.

@theobarberbany
Copy link
Author

/cherry-pick release-4.15

@openshift-cherrypick-robot

@theobarberbany: new pull request created: #59

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants