Merge https://github.com/kubernetes/cloud-provider-openstack:master into master #153
Conversation
![shiftstack-merge-bot[bot]](https://avatars.githubusercontent.com/u/48560946?s=60&v=4){kind=small}
shiftstack-merge-bot-cloner
bot
force-pushed
the
merge-bot-master
branch
from
b58ebf1
to
50b2349
Compare
openshift-ci
bot
added
the
needs-ok-to-test
|
Hi @shiftstack-merge-bot[bot]. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/hold I'd rather merge #152 first for easiness of cherry-picks later. |
openshift-ci
bot
added
the
do-not-merge/hold
|
This looks wrong, 739b317 is already in. |
|
/close Okay, this was never updated by mergebot, I'll just close it so mergebot will create a new one. |
|
@dulek: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/open |
|
/repoen |
|
/reopen |
|
@dulek: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
openshift-ci
bot
added
ok-to-test
shiftstack-merge-bot-cloner
bot
force-pushed
the
merge-bot-master
branch
from
50b2349
to
15a5f0d
Compare
|
Looks pretty good, but let's retry. /retest |
|
/override ci/prow/e2e-openstack Just usual test complaining about etcd performance on Vexxhost. |
|
@dulek: Overrode contexts on behalf of dulek: ci/prow/e2e-openstack In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@shiftstack-merge-bot[bot]: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
/approve Okay, this really just upgrades gophercloud, I bet we're cool with that. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dulek, shiftstack-merge-bot[bot] The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
No description provided.