Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add k8s.io/dynamic-resource-allocation to indirect deps #165

Closed
wants to merge 1 commit into from

Conversation

dulek
Copy link

@dulek dulek commented Jan 9, 2023

Looks like we should set v1.26 for that dependency as v0.0.0 won't work. This commit does so.

@openshift-ci openshift-ci bot requested review from EmilienM and gryf January 9, 2023 20:25
@openshift-ci
Copy link

openshift-ci bot commented Jan 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dulek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2023
@dulek
Copy link
Author

dulek commented Jan 9, 2023

/hold

I'm totally not sure if what I'm doing here makes sense. @pierreprinetti, can you help me?

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 9, 2023
Looks like we should set v1.26 for that dependency as v0.0.0 won't work.
This commit does so.
@dulek
Copy link
Author

dulek commented Jan 10, 2023

This should probably go upstream first.

@dulek dulek closed this Jan 10, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jan 10, 2023

@dulek: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack 6681316 link true /test e2e-openstack
ci/prow/unit 6681316 link true /test unit
ci/prow/images 6681316 link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant