Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge https://github.com/kubernetes/cloud-provider-openstack:release-1.23 into release-4.10 #167

Conversation

shiftstack-merge-bot[bot]
Copy link

No description provided.

lingxiankong and others added 14 commits January 13, 2022 17:04
Co-authored-by: Lingxian Kong <anlin.kong@gmail.com>
Cinder v2 has been deprecated since Pike release, let's use v3.
…etes#1916)

* POC PKCS8

* formatting fix with gofmt

Co-authored-by: Laurence Gill <laurencegill@users.noreply.github.com>
This PR pinns k3s to v1.23.6+k3s1. We stick with that as long as we
can't reliably say that newer versions work well enough for us.
In the future, we must change code for k3s-v1.24.0 anywayse, because
docker is not supported there anyways. Until we change away from docker
we can't update to v1.24.
… not exist (kubernetes#1913) (kubernetes#1918)

Co-authored-by: Ismail Alidzhikov <i.alidjikov@gmail.com>
Author:    Florin Peter <public@florin-peter.de>

Co-authored-by: Florin Peter <public@florin-peter.de>
…rder for node addresses (kubernetes#2031)

* Support specifying a sort order for node addresses

This introduces a configuration key which influences the way the
provider reports the node addresses to the Kubernetes node resource.

The default order depends on the hard-coded order the provider queries
the addresses and what the cloud returns, which does not guarantee a
specific order.

To override this behavior it is possible to specify a comma separated
list of CIDRs. Essentially, this will sort and group all addresses
matching a CIDR in a prioritized manner, where the first item having a
higher priority than the last. All non-matching addresses will remain in
the same order they are already in.

For example, this option can be useful when having multiple or
dual-stack interfaces attached to a node and needing a user-controlled,
deterministic way of sorting the addresses.

* Update gofmt for various files
@mandre
Copy link
Member

mandre commented Jan 11, 2023

OK, I wanted to check the bot would produce the same PR I did manually in #158. We'll close one of them.

@openshift-ci
Copy link

openshift-ci bot commented Jan 11, 2023

@shiftstack-merge-bot[bot]: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Merge https://github.com/kubernetes/cloud-provider-openstack:release-1.23 into release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 11, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jan 11, 2023

Hi @shiftstack-merge-bot[bot]. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Jan 11, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shiftstack-merge-bot[bot]
Once this PR has been reviewed and has the lgtm label, please assign elmiko for approval by writing /assign @elmiko in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mandre
Copy link
Member

mandre commented Jan 16, 2023

Dup of #158
/close

@openshift-ci openshift-ci bot closed this Jan 16, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jan 16, 2023

@mandre: Closed this PR.

In response to this:

Dup of #158
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mandre mandre deleted the merge-bot-release-4.10 branch January 19, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants