Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge https://github.com/kubernetes/cloud-provider-openstack:release-1.22 into release-4.9 #182

Conversation

shiftstack-merge-bot[bot]
Copy link

No description provided.

@openshift-ci
Copy link

openshift-ci bot commented Feb 16, 2023

@shiftstack-merge-bot[bot]: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Merge https://github.com/kubernetes/cloud-provider-openstack:release-1.22 into release-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Feb 16, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shiftstack-merge-bot[bot]
Once this PR has been reviewed and has the lgtm label, please assign pierreprinetti for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 16, 2023
@openshift-ci
Copy link

openshift-ci bot commented Feb 16, 2023

Hi @shiftstack-merge-bot[bot]. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierreprinetti
Copy link
Member

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 7, 2023
@openshift-ci
Copy link

openshift-ci bot commented Mar 7, 2023

@shiftstack-merge-bot[bot]: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-csi-manila 796ac9b link false /test e2e-openstack-csi-manila
ci/prow/unit 796ac9b link true /test unit
ci/prow/e2e-openstack-csi-cinder 796ac9b link false /test e2e-openstack-csi-cinder
ci/prow/images 796ac9b link true /test images
ci/prow/e2e-openstack 796ac9b link true /test e2e-openstack

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pierreprinetti
Copy link
Member

The upstream branch is not compatible with Go v1.16 any more. Since this branch is going EOL on 2023-24-18, I propose to keep an eye on syncs and only act if there is a security fix before that date.

@mandre
Copy link
Member

mandre commented Apr 6, 2023

/hold
We can close when 4.9 becomes EOL, in less than 2 weeks.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 6, 2023
@mandre
Copy link
Member

mandre commented May 30, 2023

release-4.9 is EOL
/close

@openshift-ci openshift-ci bot closed this May 30, 2023
@openshift-ci
Copy link

openshift-ci bot commented May 30, 2023

@mandre: Closed this PR.

In response to this:

release-4.9 is EOL
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierreprinetti pierreprinetti deleted the merge-bot-release-4.9 branch October 20, 2023 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants