Merge https://github.com/kubernetes/cloud-provider-openstack:master into master #206
Conversation
![shiftstack-merge-bot[bot]](https://avatars.githubusercontent.com/u/48560946?s=60&v=4){kind=small}
* Use errors.IsNotFound() SG management code used its own function to check if `err` is a 404. We have a dedicated function for that, let's use it there too. * Make sure SGs are deleted when CPO is reconfigured If we reconfigure CPO to set `manage-security-groups=true`, it will correctly reconcile LBs to make sure SGs are created and associated with nodes. This commit makes sure that SGs are properly deleted when CPO is reconfigured in opposite direction, with `manage-security-groups=false`.
OVN keeps the source IP of the incoming traffic. This means that the SG on the members of the LB (nodes) needs to have a rule opening traffic not only from inside the cluster, but also elsewhere. This can restricted by using the `Service.Spec.LoadBalancerSourceRanges` and this commit also makes sure the setting is taken into account.
openshift-ci
bot
added
the
needs-ok-to-test
|
Hi @shiftstack-merge-bot[bot]. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
openshift-ci
bot
added
ok-to-test
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dulek, shiftstack-merge-bot[bot] The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@shiftstack-merge-bot[bot]: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
No description provided.