Get latest changes from upstream #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing myself from OWNERS as I am no longer actively participating
All the repos from staging, now come with their own tags. See #84608
NodeUnpublishVolume and NodeUnstageVolume should just return NotFound if the volume with the volume_id does not exist. Meaning in this case... does not exist in openstack any more. Not being mounted any more is a valid case. Imaging e.g. umount, pv updated, another trigger of umount. https://github.com/container-storage-interface/spec/blob/master/spec.md#nodeunpublishvolume-errors https://github.com/container-storage-interface/spec/blob/master/spec.md#nodeunstagevolume-errors
(cherry picked from commit 08e36e4) Signed-off-by: Bharat Kunwar <brtknr@bath.edu>
* removed hardcoded user agent name from manilaclient * manila-provisioner refactoring: use pkg/csi/manila/manilaclient as manila client * fixed tests
…#884) * CCM: set predicted and proper server ip addresses order * code review
* added cloud-provider-openstack-acceptance-test-csi-manila * added trigger whitelist for csi-manila job
…ernetes#908) * retrieve only public share type extra specs * updated unit tests
…bernetes#881) * removed responsebroker * replaced responsebroker, make use of ABORTED error code This commit replaces responsebroker with sync.Map as a means of signaling whether an operation is in progress. If there's a pending CreateVolume/CreateSnapshot on a volume/snapshot with the same name, the RPC will now return ABORTED error code. This means that in any given time there will be only one goroutine waiting for a particular resource to complete its creation. * call tryDeleteSnapshot before returning on error
like volume, we need create description and prop for snapshot (part) of the result looks like: +--------------------------------------------+----------------------------------------------+ | created_at | 2019-06-28T01:25:10.000000 | | description | Created by OpenStack Cinder CSI driver | | id | 823c9947-b8ee-464a-9413-eff84869b098 | | properties | cinder.csi.openstack.org/cluster='ClusterID' | +--------------------------------------------+----------------------------------------------+
during some debug found some logs are not need to be enabled by default..
* [WIP] Remove inactive reviewers/approvers from OWNERS Remove inactive approvers/reviewers from OWNERS kubernetes/kubernetes#76269 used the script from dims https://gist.github.com/dims/3261edf075660ad1bf5c338b8794c21b * Update OWNERS Added ricolin
When either the volume or the instance in openstack is already gone, the ControllerUnpublishVolume assumes the volume is not attached any more. This is is the behavior DO and the GCE controller implement as well, and a sane implemetation, because between any of the code steps, an out of cluster process could have delete the volume. E.g. a test case, where the internal teardown takes longer than reaching out for cinder delete in the cleanup step.
openshift-ci-robot
added
the
size/XXL
openshift-ci-robot
added
the
approved
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Fedosin, tomassedovic The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.