Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k8s-keystone-auth: Disable HTTP/2 on the auth webhook #236

Closed
wants to merge 1 commit into from

Conversation

pierreprinetti
Copy link
Member

Prevent HTTP/2 abuse.

Is the k8s-keystone-auth tested anywhere? I am not sure that passing an empty tls.Config is like not passing it, and I'd love to have some regression testing to confirm that.

@stephenfin you've committed in this space recently. Do you perhaps know?

@openshift-ci
Copy link

openshift-ci bot commented Oct 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierreprinetti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 20, 2023
@pierreprinetti
Copy link
Member Author

/test whateverisavailable

@openshift-ci
Copy link

openshift-ci bot commented Oct 20, 2023

@pierreprinetti: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test e2e-openstack
  • /test e2e-openstack-csi-manila
  • /test images
  • /test unit

The following commands are available to trigger optional jobs:

  • /test e2e-openstack-csi-cinder
  • /test e2e-openstack-parallel

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-cloud-provider-openstack-master-e2e-openstack
  • pull-ci-openshift-cloud-provider-openstack-master-images
  • pull-ci-openshift-cloud-provider-openstack-master-unit

In response to this:

/test whateverisavailable

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierreprinetti
Copy link
Member Author

pierreprinetti commented Oct 20, 2023

@stlaz @ibihim do you perhaps know if k8s-keystone-auth is owned or tested on the Auth side?

@pierreprinetti
Copy link
Member Author

/cherrypick release-4.14

@openshift-cherrypick-robot

@pierreprinetti: once the present PR merges, I will cherry-pick it on top of release-4.14 in a new PR and assign it to you.

In response to this:

/cherrypick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Oct 20, 2023

@pierreprinetti: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pierreprinetti
Copy link
Member Author

k8s-keystone-auth is not present in the OpenShift release payload.
OpenShift's Keystone-based authentication depends on oauth-server, that doesn't use code from this repository.

My understanding is that this code is not used in OpenShift.

/close

@openshift-ci openshift-ci bot closed this Oct 23, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 23, 2023

@pierreprinetti: Closed this PR.

In response to this:

k8s-keystone-auth is not present in the OpenShift release payload.
OpenShift's Keystone-based authentication depends on oauth-server, that doesn't use code from this repository.

My understanding is that this code is not used in OpenShift.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierreprinetti pierreprinetti deleted the keystone_http2 branch October 23, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants