Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: Merge https://github.com/kubernetes/cloud-provider-openstack:master into master #245

Merged
merged 8 commits into from Dec 6, 2023

Conversation

shiftstack-merge-bot[bot]
Copy link

No description provided.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 9, 2023
Copy link

openshift-ci bot commented Nov 9, 2023

Hi @shiftstack-merge-bot[bot]. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dulek
Copy link

dulek commented Nov 9, 2023

/hold

Doesn't affect us yet, no need to run CI.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 9, 2023
@dulek
Copy link

dulek commented Nov 16, 2023

Still nothing important.

@dulek
Copy link

dulek commented Nov 28, 2023

Docs update is still not too important for us.

@dulek
Copy link

dulek commented Nov 30, 2023

/ok-to-test
/retitle NOJIRA: Merge https://github.com/kubernetes/cloud-provider-openstack:master into master

Despite this not really having functional value, I'm going to allow merging this before branching to anticipate future backports.

@openshift-ci openshift-ci bot changed the title Merge https://github.com/kubernetes/cloud-provider-openstack:master into master NOJIRA: Merge https://github.com/kubernetes/cloud-provider-openstack:master into master Nov 30, 2023
@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 30, 2023
@dulek
Copy link

dulek commented Nov 30, 2023

/retest

@dulek
Copy link

dulek commented Nov 30, 2023

/retitle NO-JIRA: Merge https://github.com/kubernetes/cloud-provider-openstack:master into master

@openshift-ci openshift-ci bot changed the title NOJIRA: Merge https://github.com/kubernetes/cloud-provider-openstack:master into master NO-JIRA: Merge https://github.com/kubernetes/cloud-provider-openstack:master into master Nov 30, 2023
@dulek
Copy link

dulek commented Nov 30, 2023

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 30, 2023
@openshift-ci-robot
Copy link

@shiftstack-merge-bot[bot]: This pull request explicitly references no jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2023
Copy link

openshift-ci bot commented Nov 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dulek, shiftstack-merge-bot[bot]

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2023
@dulek
Copy link

dulek commented Nov 30, 2023

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 30, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 6a2f019 and 2 for PR HEAD fbe5ff0 in total

@dulek
Copy link

dulek commented Dec 1, 2023

/retest

1 similar comment
@dulek
Copy link

dulek commented Dec 6, 2023

/retest

Copy link

openshift-ci bot commented Dec 6, 2023

@shiftstack-merge-bot[bot]: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 12cf77f into openshift:master Dec 6, 2023
4 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build csi-driver-manila-container-v4.15.0-202312070130.p0.g12cf77f.assembly.stream for distgit csi-driver-manila.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants