Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge https://github.com/kubernetes/cloud-provider-openstack:release-1.29 into master #266

Closed

Conversation

shiftstack-merge-bot[bot]
Copy link

No description provided.

…nto master

Conflicts:
       OWNERS
       pkg/openstack/OWNERS
…enshift-4.10-ose-openstack-cloud-controller-manager

Updating ose-openstack-cloud-controller-manager images to be consistent with ART
…enshift-4.10-csi-driver-manila

Updating csi-driver-manila images to be consistent with ART
…enshift-4.10-ose-openstack-cinder-csi-driver

Updating ose-openstack-cinder-csi-driver images to be consistent with ART
Bug 2034537: OWNERS: Update ShiftStack members
shiftstack-merge-bot and others added 18 commits December 7, 2023 12:03
…penshift-4.16-ose-openstack-cinder-csi-driver

OCPBUGS-24944: Updating ose-openstack-cinder-csi-driver-container image to be consistent with ART
…penshift-4.16-ose-openstack-cloud-controller-manager

OCPBUGS-24897: Updating ose-openstack-cloud-controller-manager-container image to be consistent with ART
…penshift-4.16-ose-openstack-cinder-csi-driver

OCPBUGS-24944: Updating ose-openstack-cinder-csi-driver-container image to be consistent with ART
…penshift-4.16-csi-driver-manila

OCPBUGS-25014: Updating csi-driver-manila-container image to be consistent with ART
…penshift-4.16-csi-driver-manila

OCPBUGS-25014: Updating csi-driver-manila-container image to be consistent with ART
…penshift-4.16-ose-openstack-cinder-csi-driver

OCPBUGS-24944: Updating ose-openstack-cinder-csi-driver-container image to be consistent with ART
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 6, 2024
Copy link

openshift-ci bot commented Feb 6, 2024

Hi @shiftstack-merge-bot[bot]. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from dulek and mdbooth February 6, 2024 09:16
Copy link

openshift-ci bot commented Feb 6, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shiftstack-merge-bot[bot]
Once this PR has been reviewed and has the lgtm label, please assign nrb for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mandre
Copy link
Member

mandre commented Feb 6, 2024

We may want to manually rebase on top of release-1.29 instead.
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 6, 2024
@mandre
Copy link
Member

mandre commented Feb 9, 2024

We've rebased on upstream stable branch. No longer needed.
/close

@openshift-ci openshift-ci bot closed this Feb 9, 2024
Copy link

openshift-ci bot commented Feb 9, 2024

@mandre: Closed this PR.

In response to this:

We've rebased on upstream stable branch. No longer needed.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mandre mandre deleted the merge-bot-master branch February 12, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants