Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.15] OCPBUGS-32246: Remove enforcement of IPv6 LB as internal #277

Merged
merged 1 commit into from Apr 24, 2024
Merged

[release-4.15] OCPBUGS-32246: Remove enforcement of IPv6 LB as internal #277

merged 1 commit into from Apr 24, 2024

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #275

/assign MaysaMacedo

@MaysaMacedo
Remove enforcement of IPv6 LB as internal (kubernetes#2557) (kubernet…
8332fa3 
…es#2566)

In OpenStack IPv6 that uses GUAs don't require NAT
to access the outside world, so IPv6 can be
rechable without Floating IPs, which makes the
enforcement of IPv6 LB as internal in CPO not necessary.
This commit removes this enforcement, which results in
IPv6 load-balancers being allowed to be shared between
Services. Also, now it's possible to make the load-balancer
use the IPv6 stateful address defined in the loadBalancerIP
of the Service.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 15, 2024
Merged
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-29605 has been cloned as Jira Issue OCPBUGS-32246. Will retitle bug to link to clone.
/retitle [release-4.15] OCPBUGS-32246: Remove enforcement of IPv6 LB as internal

In response to this:

This is an automated cherry-pick of #275

/assign MaysaMacedo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.15] OCPBUGS-29605: Remove enforcement of IPv6 LB as internal [release-4.15] OCPBUGS-32246: Remove enforcement of IPv6 LB as internal Apr 15, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 15, 2024
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-32246, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"
  • expected dependent Jira Issue OCPBUGS-29605 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead
  • expected dependent Jira Issue OCPBUGS-29605 to target a version in 4.16.0, but it targets "4.16" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #275

/assign MaysaMacedo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@MaysaMacedo
Copy link

/cc @dulek

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 15, 2024

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dulek
Copy link

dulek commented Apr 16, 2024

/hold
/lgtm
/approve

I'm approving, but this needs openshift/cluster-cloud-controller-manager-operator#339 in first.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 16, 2024
@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 16, 2024
@MaysaMacedo
Copy link

/jira refresh

@openshift-ci-robot
Copy link

@MaysaMacedo: This pull request references Jira Issue OCPBUGS-32246, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot mentioned this pull request Apr 24, 2024
Merged
@eurijon
Copy link

eurijon commented Apr 24, 2024

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 24, 2024
mandre
mandre reviewed Apr 24, 2024
View reviewed changes
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Apr 24, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dulek, mandre, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dulek
Copy link

dulek commented Apr 24, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 24, 2024
@openshift-ci-robot
Copy link

@dulek: This pull request references Jira Issue OCPBUGS-32246, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.z) matches configured target version for branch (4.15.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-29605 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-29605 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (itbrown@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dulek
Copy link

dulek commented Apr 24, 2024

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 24, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit d85d23f into openshift:release-4.15 Apr 24, 2024
4 checks passed
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-32246: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-32246 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #275

/assign MaysaMacedo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build csi-driver-manila-container-v4.15.0-202404241208.p0.gd85d23f.assembly.stream.el9 for distgit csi-driver-manila.
All builds following this will include this PR.

@openshift-merge-robot
Copy link

Fix included in accepted release 4.15.0-0.nightly-2024-04-25-145602

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mandre mandre mandre left review comments

@dulek dulek Awaiting requested review from dulek

@MaysaMacedo MaysaMacedo Awaiting requested review from MaysaMacedo

Assignees

@dulek dulek

@mandre mandre

@eurijon eurijon

@MaysaMacedo MaysaMacedo

@itzikb-redhat itzikb-redhat

@rlobillo rlobillo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@openshift-cherrypick-robot @openshift-ci-robot @MaysaMacedo @dulek @eurijon @openshift-bot @openshift-merge-robot @mandre @itzikb-redhat @rlobillo