Bug 1906732: Add E2E to ensure Cluster Wide Proxies are honoured in Machine API components #192

rvanderp3 · 2020-10-09T20:51:37Z

No description provided.

openshift-ci-robot · 2020-10-09T20:51:55Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

JoelSpeed

This is great, left a few comments which are pretty much all stylistic nit picks, please update as appropriate

pkg/operators/machine-api-operator.go

pkg/framework/proxies.go

pkg/framework/pods.go

rvanderp3 · 2020-10-14T20:04:58Z

/test

openshift-ci-robot · 2020-10-14T20:05:16Z

@rvanderp3: The /test command needs one or more targets.
The following commands are available to trigger jobs:

/test e2e-aws-operator
/test e2e-aws-operator-tech-preview
/test e2e-azure-operator
/test e2e-gcp-operator
/test goimports
/test golint
/test govet
/test images

Use /test all to run the following jobs:

pull-ci-openshift-cluster-api-actuator-pkg-master-e2e-aws-operator
pull-ci-openshift-cluster-api-actuator-pkg-master-e2e-azure-operator
pull-ci-openshift-cluster-api-actuator-pkg-master-e2e-gcp-operator
pull-ci-openshift-cluster-api-actuator-pkg-master-goimports
pull-ci-openshift-cluster-api-actuator-pkg-master-golint
pull-ci-openshift-cluster-api-actuator-pkg-master-govet
pull-ci-openshift-cluster-api-actuator-pkg-master-images

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rvanderp3 · 2020-10-14T20:08:14Z

/test golint

rvanderp3 · 2020-10-14T20:11:11Z

/test govet,goimports

openshift-ci-robot · 2020-10-14T20:11:29Z

@rvanderp3: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

/test e2e-aws-operator
/test e2e-aws-operator-tech-preview
/test e2e-azure-operator
/test e2e-gcp-operator
/test goimports
/test golint
/test govet
/test images

Use /test all to run the following jobs:

pull-ci-openshift-cluster-api-actuator-pkg-master-e2e-aws-operator
pull-ci-openshift-cluster-api-actuator-pkg-master-e2e-azure-operator
pull-ci-openshift-cluster-api-actuator-pkg-master-e2e-gcp-operator
pull-ci-openshift-cluster-api-actuator-pkg-master-goimports
pull-ci-openshift-cluster-api-actuator-pkg-master-golint
pull-ci-openshift-cluster-api-actuator-pkg-master-govet
pull-ci-openshift-cluster-api-actuator-pkg-master-images

In response to this:

/test govet,goimports,govet

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rvanderp3 · 2020-10-14T20:11:50Z

/test govet

JoelSpeed · 2020-10-19T10:11:06Z

pkg/framework/proxies.go

+	corev1 "k8s.io/api/core/v1"
+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+	"k8s.io/apimachinery/pkg/util/wait"
+	"k8s.io/klog"


I think we should be using klog/v2 now

Suggested change

"k8s.io/klog"

"k8s.io/klog/v2"

this still needs to be adressed

thanks. i'll take care of that today.

pkg/framework/proxies.go

JoelSpeed · 2020-10-19T10:13:46Z

pkg/framework/proxies.go

+	var machineSet *mapiv1beta1.MachineSet
+	var machineSetParams MachineSetParams
+
+	machineSetParams = BuildMachineSetParams(client, 1)


Don't need to declare these vars up here, they can be created inline

Suggested change

var machineSet *mapiv1beta1.MachineSet

var machineSetParams MachineSetParams

machineSetParams = BuildMachineSetParams(client, 1)

machineSetParams := BuildMachineSetParams(client, 1)

JoelSpeed · 2020-10-19T10:17:27Z

pkg/framework/proxies.go

+	}
+	node := nodes[0]
+	delete(node.Labels, "node-role.kubernetes.io/worker")
+	client.Update(context.Background(), node)


Should we not check this error?

Suggested change

client.Update(context.Background(), node)

if err := client.Update(context.Background(), node); err != nil {

return nil, err

}

JoelSpeed · 2020-10-19T10:19:09Z

pkg/framework/proxies.go

+// DeployClusterProxy Deploys an HTTP proxy to the proxy node
+func DeployClusterProxy(c runtimeclient.Client) (*appsv1.Deployment, error) {
+	configMap := corev1.ConfigMap{
+		TypeMeta: metav1.TypeMeta{},


We can get rid of this one

Suggested change

TypeMeta: metav1.TypeMeta{},

JoelSpeed · 2020-10-19T10:23:58Z

pkg/framework/proxies.go

+
+// WaitForProxyInjectionSync waits for the deployment to sync with the state of the cluster-proxy
+func WaitForProxyInjectionSync(c runtimeclient.Client, name, namespace string, shouldBePresent bool) bool {
+	if err := wait.PollImmediate(RetryShort, WaitLong, func() (bool, error) {


On a WaitLong, might want to reduce the retry, perhaps RetryMedium would be more appropriate here?

JoelSpeed · 2020-10-19T10:25:03Z

pkg/framework/proxies.go

+			hasHttpsProxy &&
+			hasNoProxy) == shouldBePresent, nil
+	}); err != nil {
+		klog.Errorf("Error checking isDeploymentAvailable: %v", err)


This error message needs an update

JoelSpeed · 2020-10-19T10:27:33Z

pkg/framework/proxies.go

+	if updatedProxy.Spec.HTTPProxy != "" {
+		proxy.Spec.HTTPProxy = updatedProxy.Spec.HTTPProxy
+	} else {
+		proxy.Spec.HTTPProxy = ""
+	}
+	if updatedProxy.Spec.HTTPSProxy != "" {
+		proxy.Spec.HTTPSProxy = updatedProxy.Spec.HTTPSProxy
+	} else {
+		proxy.Spec.HTTPSProxy = ""
+	}
+	if updatedProxy.Spec.NoProxy != "" {
+		proxy.Spec.NoProxy = updatedProxy.Spec.NoProxy
+	} else {
+		proxy.Spec.NoProxy = ""
+	}


All of these can be condensed to

Suggested change

if updatedProxy.Spec.HTTPProxy != "" {

proxy.Spec.HTTPProxy = updatedProxy.Spec.HTTPProxy

} else {

proxy.Spec.HTTPProxy = ""

}

if updatedProxy.Spec.HTTPSProxy != "" {

proxy.Spec.HTTPSProxy = updatedProxy.Spec.HTTPSProxy

} else {

proxy.Spec.HTTPSProxy = ""

}

if updatedProxy.Spec.NoProxy != "" {

proxy.Spec.NoProxy = updatedProxy.Spec.NoProxy

} else {

proxy.Spec.NoProxy = ""

}

proxy.Spec.HTTPProxy = updatedProxy.Spec.HTTPProxy

proxy.Spec.HTTPSProxy = updatedProxy.Spec.HTTPSProxy

proxy.Spec.NoProxy = updatedProxy.Spec.NoProxy

But do we really need to do this? Would we not want to just c.Update(context.Background(), updatedProxy)? Do we even need this wrapper function?

very good call. when I wrote that I thought those variables inited to nil when undefined, which they don't. I'll make that change.

JoelSpeed · 2020-10-19T10:34:54Z

pkg/operators/machine-api-operator.go

+	var machineSet *mapiv1beta1.MachineSet
+	var proxyMachineSet *mapiv1beta1.MachineSet
+	var machineSetParams framework.MachineSetParams
+	It("reflect the configured proxy in machine-api-controller", func() {
+		By("creating host for proxy")
+		client, err := framework.LoadClient()
+		Expect(err).NotTo(HaveOccurred())
+		proxyMachineSet, err = framework.CreateProxyMachineSet(client)
+		Expect(err).NotTo(HaveOccurred())
+
+		By("deploying an HTTP proxy")
+		deployment, err := framework.DeployClusterProxy(client)
+		Expect(err).NotTo(HaveOccurred())
+		Expect(framework.IsDeploymentAvailable(client, deployment.Name, deployment.Namespace)).To(BeTrue())
+
+		By("configuring cluster-wide proxy")
+		pods, err := framework.GetPods(client, map[string]string{"app": "squid"})
+		Expect(err).NotTo(HaveOccurred())
+		Expect(len(pods.Items) > 0).To(BeTrue())
+		proxy := configv1.Proxy{}
+		proxy.Spec.HTTPProxy = "http://" + pods.Items[0].Status.HostIP + ":80"
+		proxy.Spec.HTTPSProxy = "http://" + pods.Items[0].Status.HostIP + ":80"
+		framework.SetClusterProxy(client, proxy)
+		Expect(err).NotTo(HaveOccurred())
+
+		By("waiting for machine-api-controller deployment to reflect configured cluster-wide proxy")
+		Expect(framework.WaitForProxyInjectionSync(client, maoManagedDeployment, framework.MachineAPINamespace, true)).To(BeTrue())
+	})
+
+	It("allow a machineset to be created and destroyed", func() {
+		client, err := framework.LoadClient()
+		Expect(err).NotTo(HaveOccurred())
+
+		By("creating a machineset")
+
+		machineSetParams = framework.BuildMachineSetParams(client, 3)
+		machineSet, err = framework.CreateMachineSet(client, machineSetParams)
+		Expect(err).ToNot(HaveOccurred())
+		framework.WaitForMachineSet(client, machineSet.GetName())
+
+		By("destroying a machineset")
+		err = client.Delete(context.Background(), machineSet)
+		Expect(err).ToNot(HaveOccurred())
+		framework.WaitForMachineSetDelete(client, machineSet)
+	})
+
+	It("reflect an unconfigured proxy in machine-api-controller", func() {
+		client, err := framework.LoadClient()
+		Expect(err).NotTo(HaveOccurred())
+
+		By("unconfiguring cluster-wide proxy")
+		proxy := configv1.Proxy{}
+		proxy.Spec.HTTPProxy = ""
+		proxy.Spec.HTTPSProxy = ""
+		framework.SetClusterProxy(client, proxy)
+		Expect(err).NotTo(HaveOccurred())
+
+		By("waiting for machine-api-controller deployment to reflect unconfigured cluster-wide proxy")
+		Expect(framework.WaitForProxyInjectionSync(client, maoManagedDeployment, framework.MachineAPINamespace, false)).To(BeTrue())
+		framework.DestroyClusterProxy(client)
+
+		Expect(proxyMachineSet != nil).To(BeTrue())
+		framework.DeleteMachineSets(client, proxyMachineSet)
+	})


This either needs to be one It statement as below, or it needs to be a BeforeEach which sets up the cluster-wide proxy and an AfterEach which cleans this up again, with the It statement being the one that creates and destroys a MachineSet

Suggested change

var machineSet *mapiv1beta1.MachineSet

var proxyMachineSet *mapiv1beta1.MachineSet

var machineSetParams framework.MachineSetParams

It("reflect the configured proxy in machine-api-controller", func() {

By("creating host for proxy")

client, err := framework.LoadClient()

Expect(err).NotTo(HaveOccurred())

proxyMachineSet, err = framework.CreateProxyMachineSet(client)

Expect(err).NotTo(HaveOccurred())

By("deploying an HTTP proxy")

deployment, err := framework.DeployClusterProxy(client)

Expect(err).NotTo(HaveOccurred())

Expect(framework.IsDeploymentAvailable(client, deployment.Name, deployment.Namespace)).To(BeTrue())

By("configuring cluster-wide proxy")

pods, err := framework.GetPods(client, map[string]string{"app": "squid"})

Expect(err).NotTo(HaveOccurred())

Expect(len(pods.Items) > 0).To(BeTrue())

proxy := configv1.Proxy{}

proxy.Spec.HTTPProxy = "http://" + pods.Items[0].Status.HostIP + ":80"

proxy.Spec.HTTPSProxy = "http://" + pods.Items[0].Status.HostIP + ":80"

framework.SetClusterProxy(client, proxy)

Expect(err).NotTo(HaveOccurred())

By("waiting for machine-api-controller deployment to reflect configured cluster-wide proxy")

Expect(framework.WaitForProxyInjectionSync(client, maoManagedDeployment, framework.MachineAPINamespace, true)).To(BeTrue())

})

It("allow a machineset to be created and destroyed", func() {

client, err := framework.LoadClient()

Expect(err).NotTo(HaveOccurred())

By("creating a machineset")

machineSetParams = framework.BuildMachineSetParams(client, 3)

machineSet, err = framework.CreateMachineSet(client, machineSetParams)

Expect(err).ToNot(HaveOccurred())

framework.WaitForMachineSet(client, machineSet.GetName())

By("destroying a machineset")

err = client.Delete(context.Background(), machineSet)

Expect(err).ToNot(HaveOccurred())

framework.WaitForMachineSetDelete(client, machineSet)

})

It("reflect an unconfigured proxy in machine-api-controller", func() {

client, err := framework.LoadClient()

Expect(err).NotTo(HaveOccurred())

By("unconfiguring cluster-wide proxy")

proxy := configv1.Proxy{}

proxy.Spec.HTTPProxy = ""

proxy.Spec.HTTPSProxy = ""

framework.SetClusterProxy(client, proxy)

Expect(err).NotTo(HaveOccurred())

By("waiting for machine-api-controller deployment to reflect unconfigured cluster-wide proxy")

Expect(framework.WaitForProxyInjectionSync(client, maoManagedDeployment, framework.MachineAPINamespace, false)).To(BeTrue())

framework.DestroyClusterProxy(client)

Expect(proxyMachineSet != nil).To(BeTrue())

framework.DeleteMachineSets(client, proxyMachineSet)

})

It("create machines when configured behind a proxy", func() {

By("creating host for proxy")

client, err := framework.LoadClient()

Expect(err).NotTo(HaveOccurred())

proxyMachineSet, err := framework.CreateProxyMachineSet(client)

Expect(err).NotTo(HaveOccurred())

By("deploying an HTTP proxy")

deployment, err := framework.DeployClusterProxy(client)

Expect(err).NotTo(HaveOccurred())

Expect(framework.IsDeploymentAvailable(client, deployment.Name, deployment.Namespace)).To(BeTrue())

By("configuring cluster-wide proxy")

pods, err := framework.GetPods(client, map[string]string{"app": "squid"})

Expect(err).NotTo(HaveOccurred())

Expect(len(pods.Items) > 0).To(BeTrue())

proxy := configv1.Proxy{}

proxy.Spec.HTTPProxy = "http://" + pods.Items[0].Status.HostIP + ":80"

proxy.Spec.HTTPSProxy = "http://" + pods.Items[0].Status.HostIP + ":80"

framework.SetClusterProxy(client, proxy)

Expect(err).NotTo(HaveOccurred())

By("waiting for machine-api-controller deployment to reflect configured cluster-wide proxy")

Expect(framework.WaitForProxyInjectionSync(client, maoManagedDeployment, framework.MachineAPINamespace, true)).To(BeTrue())

By("creating a machineset")

machineSetParams = framework.BuildMachineSetParams(client, 3)

machineSet, err = framework.CreateMachineSet(client, machineSetParams)

Expect(err).ToNot(HaveOccurred())

framework.WaitForMachineSet(client, machineSet.GetName())

By("destroying a machineset")

Expect(client.Delete(context.Background(), machineSet)).To(Succeed())

framework.WaitForMachineSetDelete(client, machineSet)

By("unconfiguring cluster-wide proxy")

proxy := configv1.Proxy{}

proxy.Spec.HTTPProxy = ""

proxy.Spec.HTTPSProxy = ""

framework.SetClusterProxy(client, proxy)

Expect(err).NotTo(HaveOccurred())

By("waiting for machine-api-controller deployment to reflect unconfigured cluster-wide proxy")

Expect(framework.WaitForProxyInjectionSync(client, maoManagedDeployment, framework.MachineAPINamespace, false)).To(BeTrue())

framework.DestroyClusterProxy(client)

Expect(proxyMachineSet != nil).To(BeTrue())

framework.DeleteMachineSets(client, proxyMachineSet)

})

JoelSpeed · 2020-10-19T10:35:45Z

pkg/operators/machine-api-operator.go

@@ -164,3 +167,71 @@ var _ = Describe("[Feature:Operators] Machine API cluster operator status should
 		Expect(framework.IsStatusAvailable(client, "machine-api")).To(BeTrue())
 	})
 })
+
+var _ = Describe("[Feature:Operators] When cluster-wide proxy is configured, Machine API cluster operator should ", func() {


I don't think this can run in parallel with other tests, I think we need to mark as serial as suggested below, but I think @elmiko can confirm this

Suggested change

var _ = Describe("[Feature:Operators] When cluster-wide proxy is configured, Machine API cluster operator should ", func() {

var _ = Describe("[Serial][Feature:Operators] When cluster-wide proxy is configured, Machine API cluster operator should ", func() {

JoelSpeed · 2020-12-02T12:25:07Z

/retest

Test failures look unrelated, infrastructure issues seemingly

JoelSpeed · 2020-12-02T17:31:14Z

/retest

rvanderp3 · 2020-12-03T01:00:06Z

/retest

JoelSpeed · 2020-12-09T14:59:30Z

/retest

JoelSpeed · 2020-12-10T10:07:48Z

/retest

JoelSpeed · 2020-12-10T11:49:41Z

/retest

alexander-demicev · 2020-12-10T13:34:29Z

pkg/framework/proxies.go

+	corev1 "k8s.io/api/core/v1"
+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+	"k8s.io/apimachinery/pkg/util/wait"
+	"k8s.io/klog"


this still needs to be adressed

rvanderp3 · 2020-12-10T17:22:10Z

/retest

rvanderp3 · 2020-12-10T19:39:33Z

/retest

JoelSpeed · 2020-12-11T10:14:33Z

There's a few nits I could make about consistency with imports and naming, but I think at this point it's better to get this merged than nitpick. Will need to create a BZ to get this merged now though. I'll get that done shortly.

/approve

Thanks for all your work on this @rvanderp3!

openshift-ci-robot · 2020-12-11T10:14:56Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

JoelSpeed · 2020-12-11T10:17:26Z

/retitle Bug 1906732: Add E2E to ensure Cluster Wide Proxies are honoured in Machine API components

openshift-ci-robot · 2020-12-11T10:17:54Z

@rvanderp3: This pull request references Bugzilla bug 1906732, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.0) matches configured target release for branch (4.7.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1906732: Add E2E to ensure Cluster Wide Proxies are honoured in Machine API components

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

alexander-demicev

Thanks!
/lgtm

openshift-ci-robot · 2020-12-11T10:26:40Z

@rvanderp3: All pull requests linked via external trackers have merged:

openshift/cluster-api-actuator-pkg#192

Bugzilla bug 1906732 has been moved to the MODIFIED state.

In response to this:

Bug 1906732: Add E2E to ensure Cluster Wide Proxies are honoured in Machine API components

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 9, 2020

openshift-ci-robot requested review from JoelSpeed and michaelgugino October 9, 2020 20:51

rvanderp3 force-pushed the cluster-proxy-machine-api branch 2 times, most recently from 2e6e886 to a34e344 Compare October 12, 2020 13:50

JoelSpeed reviewed Oct 14, 2020

View reviewed changes

rvanderp3 force-pushed the cluster-proxy-machine-api branch 3 times, most recently from e399407 to 136b47c Compare October 14, 2020 20:03

rvanderp3 marked this pull request as ready for review October 15, 2020 12:45

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 15, 2020

rvanderp3 force-pushed the cluster-proxy-machine-api branch from 136b47c to 765c38d Compare October 15, 2020 17:39

rvanderp3 marked this pull request as draft October 15, 2020 19:03

openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 15, 2020

JoelSpeed reviewed Oct 19, 2020

View reviewed changes

rvanderp3 force-pushed the cluster-proxy-machine-api branch from 765c38d to 8514125 Compare October 19, 2020 19:28

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 19, 2020

rvanderp3 force-pushed the cluster-proxy-machine-api branch 2 times, most recently from 55a7ed6 to e5a647a Compare October 21, 2020 20:45

rvanderp3 marked this pull request as ready for review October 27, 2020 13:26

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 27, 2020

rvanderp3 force-pushed the cluster-proxy-machine-api branch from e5a647a to 7281a9e Compare October 27, 2020 13:41

rvanderp3 force-pushed the cluster-proxy-machine-api branch 2 times, most recently from 2c5481d to f919381 Compare December 2, 2020 00:34

rvanderp3 force-pushed the cluster-proxy-machine-api branch 4 times, most recently from b35d351 to bbe459a Compare December 2, 2020 20:46

alexander-demicev suggested changes Dec 10, 2020

View reviewed changes

Unit test for openshift/machine-api-operator/pull/725

a457aa7

rvanderp3 force-pushed the cluster-proxy-machine-api branch from bbe459a to a457aa7 Compare December 10, 2020 14:02

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 11, 2020

openshift-ci-robot changed the title ~~Unit test for openshift/machine-api-operator/pull/725~~ Bug 1906732: Add E2E to ensure Cluster Wide Proxies are honoured in Machine API components Dec 11, 2020

openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Dec 11, 2020

alexander-demicev approved these changes Dec 11, 2020

View reviewed changes

openshift-ci-robot assigned alexander-demicev Dec 11, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2020

openshift-merge-robot merged commit b830442 into openshift:master Dec 11, 2020

-	client.Update(context.Background(), node)
+	if err := client.Update(context.Background(), node); err != nil {
+		return nil, err
+	}

	var _ = Describe("[Feature:Operators] When cluster-wide proxy is configured, Machine API cluster operator should ", func() {
	var _ = Describe("[Serial][Feature:Operators] When cluster-wide proxy is configured, Machine API cluster operator should ", func() {

Bug 1906732: Add E2E to ensure Cluster Wide Proxies are honoured in Machine API components #192

Bug 1906732: Add E2E to ensure Cluster Wide Proxies are honoured in Machine API components #192

Conversation

rvanderp3 commented Oct 9, 2020

openshift-ci-robot commented Oct 9, 2020

JoelSpeed left a comment

Choose a reason for hiding this comment

rvanderp3 commented Oct 14, 2020

openshift-ci-robot commented Oct 14, 2020

rvanderp3 commented Oct 14, 2020

rvanderp3 commented Oct 14, 2020 • edited

openshift-ci-robot commented Oct 14, 2020

rvanderp3 commented Oct 14, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JoelSpeed commented Dec 2, 2020

JoelSpeed commented Dec 2, 2020

rvanderp3 commented Dec 3, 2020

JoelSpeed commented Dec 9, 2020

JoelSpeed commented Dec 10, 2020

JoelSpeed commented Dec 10, 2020

Choose a reason for hiding this comment

rvanderp3 commented Dec 10, 2020

rvanderp3 commented Dec 10, 2020

JoelSpeed commented Dec 11, 2020

openshift-ci-robot commented Dec 11, 2020

JoelSpeed commented Dec 11, 2020

openshift-ci-robot commented Dec 11, 2020

alexander-demicev left a comment

Choose a reason for hiding this comment

openshift-ci-robot commented Dec 11, 2020

rvanderp3 commented Oct 14, 2020 •

edited