Bug 1914837: Re-enable termination handler tests #202

JoelSpeed · 2020-12-15T10:40:15Z

Reverts #197 which disabled the termination handler tests to allow us to migrate from the deletion implementation to the conditions implementation

openshift-ci-robot · 2020-12-15T10:56:24Z

@JoelSpeed: This pull request references Bugzilla bug 1907286, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.0) matches configured target release for branch (4.7.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1907286: Re-enable termination handler tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

JoelSpeed · 2020-12-15T10:56:29Z

Attached this bug as the tests should only pass once this bug is resolved

openshift-merge-robot · 2020-12-15T12:54:14Z

@JoelSpeed: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-gcp-operator	`408c4db`	link	`/test e2e-gcp-operator`
ci/prow/e2e-aws-operator	`408c4db`	link	`/test e2e-aws-operator`
ci/prow/e2e-azure-operator	`408c4db`	link	`/test e2e-azure-operator`
ci/prow/e2e-vsphere-operator	`408c4db`	link	`/test e2e-vsphere-operator`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

elmiko · 2020-12-15T19:38:35Z

/approve

openshift-ci-robot · 2020-12-15T19:38:58Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elmiko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [elmiko]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

JoelSpeed · 2021-01-07T12:12:10Z

/test e2e-gcp-operator
/test e2e-vsphere-operator
/test e2e-aws-operator

JoelSpeed · 2021-01-08T13:05:26Z

/retest

JoelSpeed · 2021-01-11T10:14:18Z

/retest

openshift-ci-robot · 2021-01-11T10:16:43Z

@JoelSpeed: An error was encountered adding this pull request to the external tracker bugs for bug 1914837 on the Bugzilla server at https://bugzilla.redhat.com. We were able to detect the following conditions from the error:

The Bugzilla server failed to load data from GitHub when creating the bug. This is usually caused by rate-limiting, please try again later.

Full error message.


JSONRPC error 32000: There was an error reported for the RPC call to Jira: There was an error reported for a GitHub REST call. URL: https://api.github.com/repos/openshift/cluster-api-actuator-pkg/pulls/202 Error: 403 Forbidden at /loader/0x55958171e9b0/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 111. at /loader/0x55958171e9b0/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 111. eval {...} called at /loader/0x55958171e9b0/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 98 Bugzilla::Extension::ExternalBugs::Type::GitHub::_do_rest_call('Bugzilla::Extension::ExternalBugs::Type::GitHub=HASH(0x559587...', 'https://api.github.com/repos/openshift/cluster-api-actuator-p...', 'GET') called at /loader/0x55958171e9b0/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 62 Bugzilla::Extension::ExternalBugs::Type::GitHub::get_data('Bugzilla::Extension::ExternalBugs::Type::GitHub=HASH(0x559587...', 'Bugzilla::Extension::ExternalBugs::Bug=HASH(0x559586c5d3b8)') called at /loader/0x55958171e9b0/Bugzilla/Extension/ExternalBugs/Bug.pm line 302 eval {...} called at /loader/0x55958171e9b0/Bugzilla/Extension/ExternalBugs/Bug.pm line 302 Bugzilla::Extension::ExternalBugs::Bug::update_ext_info('Bugzilla::Extension::ExternalBugs::Bug=HASH(0x559586c5d3b8)', 1) called at /loader/0x55958171e9b0/Bugzilla/Extension/ExternalBugs/Bug.pm line 125 Bugzilla::Extension::ExternalBugs::Bug::create('Bugzilla::Extension::ExternalBugs::Bug', 'HASH(0x5595869da860)') called at /var/www/html/bugzilla/extensions/ExternalBugs/Extension.pm line 940 Bugzilla::Extension::ExternalBugs::bug_start_of_update('Bugzilla::Extension::ExternalBugs=HASH(0x559588fe5108)', 'HASH(0x55958a4d6750)') called at /var/www/html/bugzilla/Bugzilla/Hook.pm line 21 Bugzilla::Hook::process('bug_start_of_update', 'HASH(0x55958a4d6750)') called at /var/www/html/bugzilla/Bugzilla/Bug.pm line 1173 Bugzilla::Bug::update('Bugzilla::Bug=HASH(0x5595871c5900)') called at /loader/0x55958171e9b0/Bugzilla/Extension/ExternalBugs/WebService.pm line 88 Bugzilla::Extension::ExternalBugs::WebService::add_external_bug('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x55958715bbd8)') called at (eval 2000) line 1 eval ' $procedure->{code}->($self, @params) ;' called at /usr/share/perl5/vendor_perl/JSON/RPC/Legacy/Server.pm line 220 JSON::RPC::Legacy::Server::_handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x55958715dcb0)') called at /var/www/html/bugzilla/Bugzilla/WebService/Server/JSONRPC.pm line 297 Bugzilla::WebService::Server::JSONRPC::_handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x55958715dcb0)') called at /usr/share/perl5/vendor_perl/JSON/RPC/Legacy/Server.pm line 126 JSON::RPC::Legacy::Server::handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...') called at /var/www/html/bugzilla/Bugzilla/WebService/Server/JSONRPC.pm line 70 Bugzilla::WebService::Server::JSONRPC::handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...') called at /var/www/html/bugzilla/jsonrpc.cgi line 31 ModPerl::ROOT::Bugzilla::ModPerl::ResponseHandler::var_www_html_bugzilla_jsonrpc_2ecgi::handler('Apache2::RequestRec=SCALAR(0x559587e5dd50)') called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 207 eval {...} called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 207 ModPerl::RegistryCooker::run('Bugzilla::ModPerl::ResponseHandler=HASH(0x55958717a438)') called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 173 ModPerl::RegistryCooker::default_handler('Bugzilla::ModPerl::ResponseHandler=HASH(0x55958717a438)') called at /usr/lib64/perl5/vendor_perl/ModPerl/Registry.pm line 32 ModPerl::Registry::handler('Bugzilla::ModPerl::ResponseHandler', 'Apache2::RequestRec=SCALAR(0x559587e5dd50)') called at /var/www/html/bugzilla/mod_perl.pl line 139 Bugzilla::ModPerl::ResponseHandler::handler('Bugzilla::ModPerl::ResponseHandler', 'Apache2::RequestRec=SCALAR(0x559587e5dd50)') called at (eval 2000) line 0 eval {...} called at (eval 2000) line 0 at /var/www/html/bugzilla/Bugzilla/Error.pm line 130. Bugzilla::Error::_throw_error('global/user-error.html.tmpl', 'ext_bz_rest_error', 'HASH(0x559587b27950)') called at /var/www/html/bugzilla/Bugzilla/Error.pm line 193 Bugzilla::Error::ThrowUserError('ext_bz_rest_error', 'HASH(0x559587b27950)') called at /loader/0x55958171e9b0/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 120 Bugzilla::Extension::ExternalBugs::Type::GitHub::_do_rest_call('Bugzilla::Extension::ExternalBugs::Type::GitHub=HASH(0x559587...', 'https://api.github.com/repos/openshift/cluster-api-actuator-p...', 'GET') called at /loader/0x55958171e9b0/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 62 Bugzilla::Extension::ExternalBugs::Type::GitHub::get_data('Bugzilla::Extension::ExternalBugs::Type::GitHub=HASH(0x559587...', 'Bugzilla::Extension::ExternalBugs::Bug=HASH(0x559586c5d3b8)') called at /loader/0x55958171e9b0/Bugzilla/Extension/ExternalBugs/Bug.pm line 302 eval {...} called at /loader/0x55958171e9b0/Bugzilla/Extension/ExternalBugs/Bug.pm line 302 Bugzilla::Extension::ExternalBugs::Bug::update_ext_info('Bugzilla::Extension::ExternalBugs::Bug=HASH(0x559586c5d3b8)', 1) called at /loader/0x55958171e9b0/Bugzilla/Extension/ExternalBugs/Bug.pm line 125 Bugzilla::Extension::ExternalBugs::Bug::create('Bugzilla::Extension::ExternalBugs::Bug', 'HASH(0x5595869da860)') called at /var/www/html/bugzilla/extensions/ExternalBugs/Extension.pm line 940 Bugzilla::Extension::ExternalBugs::bug_start_of_update('Bugzilla::Extension::ExternalBugs=HASH(0x559588fe5108)', 'HASH(0x55958a4d6750)') called at /var/www/html/bugzilla/Bugzilla/Hook.pm line 21 Bugzilla::Hook::process('bug_start_of_update', 'HASH(0x55958a4d6750)') called at /var/www/html/bugzilla/Bugzilla/Bug.pm line 1173 Bugzilla::Bug::update('Bugzilla::Bug=HASH(0x5595871c5900)') called at /loader/0x55958171e9b0/Bugzilla/Extension/ExternalBugs/WebService.pm line 88 Bugzilla::Extension::ExternalBugs::WebService::add_external_bug('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x55958715bbd8)') called at (eval 2000) line 1 eval ' $procedure->{code}->($self, @params) ;' called at /usr/share/perl5/vendor_perl/JSON/RPC/Legacy/Server.pm line 220 JSON::RPC::Legacy::Server::_handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x55958715dcb0)') called at /var/www/html/bugzilla/Bugzilla/WebService/Server/JSONRPC.pm line 297 Bugzilla::WebService::Server::JSONRPC::_handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x55958715dcb0)') called at /usr/share/perl5/vendor_perl/JSON/RPC/Legacy/Server.pm line 126 JSON::RPC::Legacy::Server::handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...') called at /var/www/html/bugzilla/Bugzilla/WebService/Server/JSONRPC.pm line 70 Bugzilla::WebService::Server::JSONRPC::handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...') called at /var/www/html/bugzilla/jsonrpc.cgi line 31 ModPerl::ROOT::Bugzilla::ModPerl::ResponseHandler::var_www_html_bugzilla_jsonrpc_2ecgi::handler('Apache2::RequestRec=SCALAR(0x559587e5dd50)') called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 207 eval {...} called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 207 ModPerl::RegistryCooker::run('Bugzilla::ModPerl::ResponseHandler=HASH(0x55958717a438)') called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 173 ModPerl::RegistryCooker::default_handler('Bugzilla::ModPerl::ResponseHandler=HASH(0x55958717a438)') called at /usr/lib64/perl5/vendor_perl/ModPerl/Registry.pm line 32 ModPerl::Registry::handler('Bugzilla::ModPerl::ResponseHandler', 'Apache2::RequestRec=SCALAR(0x559587e5dd50)') called at /var/www/html/bugzilla/mod_perl.pl line 139 Bugzilla::ModPerl::ResponseHandler::handler('Bugzilla::ModPerl::ResponseHandler', 'Apache2::RequestRec=SCALAR(0x559587e5dd50)') called at (eval 2000) line 0 eval {...} called at (eval 2000) line 0

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

Bug 1914837: Re-enable termination handler tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

JoelSpeed · 2021-01-14T16:51:32Z

/retest

JoelSpeed · 2021-01-18T12:09:12Z

/test e2e-gcp-operator

JoelSpeed · 2021-01-19T11:59:36Z

I ran the spot test locally against a GCP 4.7 cluster and it worked as expected, not sure why it would be failing in CI
/test e2e-gcp-operator

JoelSpeed · 2021-01-19T12:19:25Z

/test e2e-gcp-operator

JoelSpeed · 2021-01-20T12:33:31Z

/test e2e-gcp-operator

openshift-bot · 2021-04-20T19:05:43Z

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

JoelSpeed · 2021-04-21T09:58:59Z

/lifecycle frozen

openshift-ci-robot · 2021-04-21T09:58:59Z

@JoelSpeed: The lifecycle/frozen label cannot be applied to Pull Requests.

In response to this:

/lifecycle frozen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

JoelSpeed · 2021-04-21T10:03:40Z

/remove-lifecycle stale

openshift-bot · 2021-07-11T11:02:44Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-11T13:51:45Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-11T15:15:45Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-11T17:27:46Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-11T17:51:45Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-11T18:51:46Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-11T19:15:46Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-11T20:39:46Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-11T21:27:45Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-11T22:27:46Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-12T00:03:46Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-12T01:15:46Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-12T01:51:48Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-12T02:27:45Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-12T03:15:46Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-12T05:03:46Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-12T05:15:45Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-12T07:27:46Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-12T07:39:47Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-07-12T09:01:31Z

@JoelSpeed: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-vsphere-operator	`408c4db`	link	`/test e2e-vsphere-operator`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2021-07-12T09:03:46Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-12T09:15:48Z

/retest

Please review the full test history for this PR and help us cut down flakes.

JoelSpeed · 2021-07-12T09:46:59Z

/override ci/prow/e2e-azure-operator

The test is permafailing, I've got a fix for that in #213. I think this is safe to override as the specific test this has re-enabled has been stable through all these restests

openshift-ci · 2021-07-12T09:47:59Z

@JoelSpeed: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

openshift/cluster-api-actuator-pkg#205 is open

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 1914837 has not been moved to the MODIFIED state.

In response to this:

Bug 1914837: Re-enable termination handler tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

JoelSpeed · 2021-07-12T09:48:55Z

/bugzilla refresh

openshift-ci · 2021-07-12T09:48:59Z

@JoelSpeed: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

openshift/cluster-api-actuator-pkg#205 is open

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 1914837 has not been moved to the MODIFIED state.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-07-12T09:50:49Z

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/e2e-azure-operator

In response to this:

/override ci/prow/e2e-azure-operator

The test is permafailing, I've got a fix for that in #213. I think this is safe to override as the specific test this has re-enabled has been stable through all these restests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot requested review from enxebre and michaelgugino December 15, 2020 10:40

JoelSpeed changed the title ~~Re-enable termination handler tests~~ Bug 1907286: Re-enable termination handler tests Dec 15, 2020

openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Dec 15, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 15, 2020

This was referenced Dec 15, 2020

Bug 1907286: Ensure Machine is marked interruptible as well as Node openshift/cluster-api-provider-gcp#140

Merged

Bug 1907286: Ensure Machine is marked interruptible as well as Node openshift/cluster-api-provider-aws#379

Merged

openshift-ci-robot mentioned this pull request Jan 8, 2021

Bug 1907286: Ensure Machine is marked interruptible as well as Node openshift/cluster-api-provider-azure#188

Merged

JoelSpeed changed the title ~~Bug 1907286: Re-enable termination handler tests~~ Bug 1914837: Re-enable termination handler tests Jan 11, 2021

JoelSpeed mentioned this pull request Jan 25, 2021

Enable spot tests with termination handler logging #205

Closed

openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 20, 2021

JoelSpeed mentioned this pull request Jul 12, 2021

Bug 1986990: WaitForValidatingWebhook should use v1 instead of removed v1beta1 #213

Merged

openshift-merge-robot merged commit 2508888 into openshift:master Jul 12, 2021

JoelSpeed deleted the revert-197-skip-spot-tests branch July 12, 2021 09:48

Bug 1914837: Re-enable termination handler tests #202

Bug 1914837: Re-enable termination handler tests #202

Conversation

JoelSpeed commented Dec 15, 2020

openshift-ci-robot commented Dec 15, 2020

JoelSpeed commented Dec 15, 2020

openshift-merge-robot commented Dec 15, 2020

elmiko commented Dec 15, 2020

openshift-ci-robot commented Dec 15, 2020

JoelSpeed commented Jan 7, 2021

JoelSpeed commented Jan 8, 2021

JoelSpeed commented Jan 11, 2021

openshift-ci-robot commented Jan 11, 2021

JoelSpeed commented Jan 14, 2021

JoelSpeed commented Jan 18, 2021

JoelSpeed commented Jan 19, 2021

JoelSpeed commented Jan 19, 2021

JoelSpeed commented Jan 20, 2021

openshift-bot commented Apr 20, 2021

JoelSpeed commented Apr 21, 2021

openshift-ci-robot commented Apr 21, 2021

JoelSpeed commented Apr 21, 2021

openshift-bot commented Jul 11, 2021

openshift-bot commented Jul 11, 2021

openshift-bot commented Jul 11, 2021

openshift-bot commented Jul 11, 2021

openshift-bot commented Jul 11, 2021

openshift-bot commented Jul 11, 2021

openshift-bot commented Jul 11, 2021

openshift-bot commented Jul 11, 2021

openshift-bot commented Jul 11, 2021

openshift-bot commented Jul 11, 2021

openshift-bot commented Jul 12, 2021

openshift-bot commented Jul 12, 2021

openshift-bot commented Jul 12, 2021

openshift-bot commented Jul 12, 2021

openshift-bot commented Jul 12, 2021

openshift-bot commented Jul 12, 2021

openshift-bot commented Jul 12, 2021

openshift-bot commented Jul 12, 2021

openshift-bot commented Jul 12, 2021

openshift-ci bot commented Jul 12, 2021 • edited

openshift-bot commented Jul 12, 2021

openshift-bot commented Jul 12, 2021

JoelSpeed commented Jul 12, 2021

openshift-ci bot commented Jul 12, 2021

JoelSpeed commented Jul 12, 2021

openshift-ci bot commented Jul 12, 2021

openshift-ci bot commented Jul 12, 2021

openshift-ci bot commented Jul 12, 2021 •

edited