Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPCLOUD-2043: Update dependencies to K8s 1.27 #280

Merged
merged 2 commits into from
May 26, 2023
Merged

OCPCLOUD-2043: Update dependencies to K8s 1.27 #280

merged 2 commits into from
May 26, 2023

Conversation

damdo
Copy link
Member

@damdo damdo commented May 15, 2023 •
edited

This updates the dependencies to the latest versions to support K8s 1.27.

TODO: update reference to machine-api-operator once openshift/machine-api-operator#1142 merges

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 15, 2023 •
edited by openshift-ci bot

@damdo: This pull request references OCPCLOUD-2043 which is a valid jira issue.

In response to this:

This updates the dependencies to the latest versions to support K8s 1.27.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 15, 2023
@damdo
Copy link
Member Author

damdo commented May 15, 2023

/hold
until openshift/machine-api-operator#1142 merges

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 15, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 15, 2023 •
edited by openshift-ci bot

@damdo: This pull request references OCPCLOUD-2043 which is a valid jira issue.

In response to this:

This updates the dependencies to the latest versions to support K8s 1.27.

TODO: update reference to machine-api-operator once openshift/machine-api-operator#1142 merges

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@damdo damdo force-pushed the bump-k8s-1.27 branch 4 times, most recently from de4b9d9 to cf1a455 Compare May 23, 2023 08:47
@JoelSpeed
Copy link
Contributor

Have you considered using a global ctx variable within the tests instead of calling context.Background() the whole time, not ideal but a pattern we've used a lot in tests before

@damdo
Copy link
Member Author

damdo commented May 23, 2023

Yes I did consider it, although I wasn't sure how long it would take and whether it was worth it.
Anyway had a go at it now and was able to get it sorted in a reasonable amount of effort.

@JoelSpeed
Copy link
Contributor

Changes look good, should probably squash the commits up though

@damdo
Copy link
Member Author

damdo commented May 23, 2023

/retest

2 similar comments
@damdo
Copy link
Member Author

damdo commented May 23, 2023

/retest

@damdo
Copy link
Member Author

damdo commented May 23, 2023

/retest

@damdo
Copy link
Member Author

damdo commented May 25, 2023

/retest

1 similar comment
@damdo
Copy link
Member Author

damdo commented May 26, 2023

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 26, 2023

@damdo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-operator 59f24e6 link false /test e2e-openstack-operator

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JoelSpeed
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 26, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2023
@JoelSpeed
Copy link
Contributor

/hold cancel

dependent PR merged and this was updated

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 26, 2023
@openshift-merge-robot openshift-merge-robot merged commit c290b1e into openshift:master May 26, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@RadekManak RadekManak Awaiting requested review from RadekManak

Assignees

@JoelSpeed JoelSpeed

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@damdo @openshift-ci-robot @JoelSpeed @openshift-merge-robot