Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPCLOUD-2416: Update Kube to v1.29 and controller-runtime to v0.17.0 #309

Merged
merged 1 commit into from
Jan 22, 2024
Merged

OCPCLOUD-2416: Update Kube to v1.29 and controller-runtime to v0.17.0 #309

merged 1 commit into from
Jan 22, 2024

Conversation

nrb
Copy link
Contributor

@nrb nrb commented Jan 17, 2024 •
edited

  • apiutil.NewDiscoveryRESTMapper deprecated in favor of apiutil.NewDynamicRESTMapper in controller-runtime v0.17.0.
  • Updated CI docker image to use Go 1.21

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 17, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 17, 2024 •
edited by openshift-ci bot

@nrb: This pull request references OCPCLOUD-2416 which is a valid jira issue.

In response to this:

  • apiutil.NewDiscoveryRESTMapper deprecated in favor of apiutil.NewDynamicRESTMapper in controller-runtime v0.17.0.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 18, 2024 •
edited by openshift-ci bot

@nrb: This pull request references OCPCLOUD-2416 which is a valid jira issue.

In response to this:

  • apiutil.NewDiscoveryRESTMapper deprecated in favor of apiutil.NewDynamicRESTMapper in controller-runtime v0.17.0.
  • Updated CI docker image to use Go 1.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@nrb
Update Kube to v1.29 and controller-runtime to v0.17.0
e94fdf7 
* apiutil.NewDiscoveryRESTMapper deprecated in favor of
  apiutil.NewDynamicRESTMapper in controller-runtime v0.17.0.
* Update CI image to use latest Golang version

Signed-off-by: Nolan Brubaker <nolan@nbrubaker.com>
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 19, 2024

@nrb: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

damdo
damdo reviewed Jan 21, 2024
View reviewed changes
Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2024
@JoelSpeed
Copy link
Contributor

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit fe84485 into openshift:master Jan 22, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damdo damdo damdo left review comments

@RadekManak RadekManak Awaiting requested review from RadekManak

Assignees

@damdo damdo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nrb @openshift-ci-robot @JoelSpeed @damdo