Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-24922: Retrieve Agent object directly #94

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

CrystalChun
Copy link

https://issues.redhat.com/browse/OCPBUGS-24922
To prevent the AgentMachine from retrieving a cached Agent (resulting in stale data).

/cc @avishayt

@openshift-ci-robot openshift-ci-robot added the jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. label Dec 12, 2023
@openshift-ci openshift-ci bot requested a review from avishayt December 12, 2023 22:25
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 12, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 12, 2023
@openshift-ci-robot
Copy link

@CrystalChun: This pull request references Jira Issue OCPBUGS-24922, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

https://issues.redhat.com/browse/OCPBUGS-24922
To prevent the AgentMachine from retrieving a cached Agent (resulting in stale data).

/cc @avishayt

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

openshift-ci bot commented Dec 12, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Dec 12, 2023
Copy link

openshift-ci bot commented Dec 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CrystalChun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 12, 2023
@CrystalChun
Copy link
Author

/test all

https://issues.redhat.com/browse/OCPBUGS-24922
To prevent the AgentMachine from retrieving a cached Agent
(resulting in stale data).
@CrystalChun
Copy link
Author

/test all

@avishayt
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 13, 2023
@CrystalChun CrystalChun marked this pull request as ready for review December 13, 2023 15:23
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 13, 2023
Copy link

openshift-ci bot commented Dec 13, 2023

@CrystalChun: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@CrystalChun
Copy link
Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Dec 14, 2023
@openshift-ci-robot
Copy link

@CrystalChun: This pull request references Jira Issue OCPBUGS-24922, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (gamado@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Dec 14, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit 00f0c9f into openshift:master Dec 14, 2023
6 checks passed
@openshift-ci-robot
Copy link

@CrystalChun: Jira Issue OCPBUGS-24922: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-24922 has been moved to the MODIFIED state.

In response to this:

https://issues.redhat.com/browse/OCPBUGS-24922
To prevent the AgentMachine from retrieving a cached Agent (resulting in stale data).

/cc @avishayt

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@CrystalChun
Copy link
Author

/cherry-pick release-ocm-2.9

@openshift-cherrypick-robot

@CrystalChun: new pull request created: #100

In response to this:

/cherry-pick release-ocm-2.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

CrystalChun added a commit to CrystalChun/cluster-api-provider-agent that referenced this pull request Mar 7, 2024
https://issues.redhat.com/browse/OCPBUGS-24922
To prevent the AgentMachine from retrieving a cached Agent
(resulting in stale data).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants