OCPBUGS-25599: Reconcile AgentMachines for unbound Agents #95
Conversation
AgentMachines need to be reconciled if they don't yet have an Agent, and and a valid Agent is modified. Otherwise AgentMachines that don't yet have an Agent will not be reconciled when an Agent becomes available.
openshift-ci-robot
added
jira/severity-important
|
@avishayt: This pull request references Jira Issue OCPBUGS-25599, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
size/L
openshift-ci
bot
added
the
approved
|
/cc @CrystalChun |
| reply := make([]reconcile.Request, 0, len(amList.Items)) | ||
| if mappedAgent { | ||
| // If the Agent is mapped to an AgentMachine, return only that AgentMachine | ||
| agent := a |
There was a problem hiding this comment.
Why is this assignment needed?
|
/retest-required Looks like a flake: |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: avishayt, CrystalChun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@avishayt: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/jira refresh |
|
@avishayt: This pull request references Jira Issue OCPBUGS-25599, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/jira refresh |
|
@avishayt: This pull request references Jira Issue OCPBUGS-25599, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@avishayt: This pull request references Jira Issue OCPBUGS-25599, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (gamado@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@avishayt: Jira Issue OCPBUGS-25599: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-25599 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is a workaround for [1], which would cause the cluster to get stuck in the "pending node assigment" stage. [1]: openshift/cluster-api-provider-agent#95
AgentMachines need to be reconciled if they don't yet have an Agent, and and a valid Agent is modified. Otherwise AgentMachines that don't yet have an Agent will not be reconciled when an Agent becomes available.
AgentMachines need to be reconciled if they don't yet have an Agent, and and a valid Agent is modified. Otherwise AgentMachines that don't yet have an Agent will not be reconciled when an Agent becomes available.