Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-27251: Requeue AgentMachine if failed to find Agent #96

Closed
wants to merge 1 commit into from

Conversation

CrystalChun
Copy link

https://issues.redhat.com/browse/OCPBUGS-27251
It's possible that there are no valid Agents when an AgentMachine is created. The Agent will become valid later, but that doesn't cause the reconcile loop to pick it up, so the AgentMachine will never end up getting an Agent without manual intervention.

This at least allows the AgentMachine to be reconciled again in the event that an existing agent does become valid.

/cc @avishayt

https://issues.redhat.com/browse/OCPBUGS-27251
It's possible that there are no valid Agents when an AgentMachine is
created. The Agent will become valid later, but that doesn't
cause the reconcile loop to pick it up, so the AgentMachine
will never end up getting an Agent without manual intervention.

This at least allows the AgentMachine to be reconciled again
in the event that an existing agent does become valid.
@openshift-ci openshift-ci bot requested a review from avishayt January 18, 2024 03:52
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 18, 2024
@openshift-ci-robot
Copy link

@CrystalChun: This pull request references Jira Issue OCPBUGS-27251, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

https://issues.redhat.com/browse/OCPBUGS-27251
It's possible that there are no valid Agents when an AgentMachine is created. The Agent will become valid later, but that doesn't cause the reconcile loop to pick it up, so the AgentMachine will never end up getting an Agent without manual intervention.

This at least allows the AgentMachine to be reconciled again in the event that an existing agent does become valid.

/cc @avishayt

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 18, 2024
Copy link

openshift-ci bot commented Jan 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CrystalChun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2024
Copy link

openshift-ci bot commented Jan 18, 2024

@CrystalChun: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@avishayt
Copy link

Reconcile should be triggered when the Agent's status is updated. I'd prefer to understand why it's not happening, if possible, before going down this route.

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 18, 2024
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 18, 2024
@CrystalChun
Copy link
Author

/close
Incorrect logic

@openshift-ci-robot
Copy link

@CrystalChun: This pull request references Jira Issue OCPBUGS-27251. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

In response to this:

https://issues.redhat.com/browse/OCPBUGS-27251
It's possible that there are no valid Agents when an AgentMachine is created. The Agent will become valid later, but that doesn't cause the reconcile loop to pick it up, so the AgentMachine will never end up getting an Agent without manual intervention.

This at least allows the AgentMachine to be reconciled again in the event that an existing agent does become valid.

/cc @avishayt

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants