-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-27251: Requeue AgentMachine if failed to find Agent #96
Conversation
https://issues.redhat.com/browse/OCPBUGS-27251 It's possible that there are no valid Agents when an AgentMachine is created. The Agent will become valid later, but that doesn't cause the reconcile loop to pick it up, so the AgentMachine will never end up getting an Agent without manual intervention. This at least allows the AgentMachine to be reconciled again in the event that an existing agent does become valid.
@CrystalChun: This pull request references Jira Issue OCPBUGS-27251, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CrystalChun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@CrystalChun: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Reconcile should be triggered when the Agent's status is updated. I'd prefer to understand why it's not happening, if possible, before going down this route. |
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
/close |
@CrystalChun: This pull request references Jira Issue OCPBUGS-27251. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
https://issues.redhat.com/browse/OCPBUGS-27251
It's possible that there are no valid Agents when an AgentMachine is created. The Agent will become valid later, but that doesn't cause the reconcile loop to pick it up, so the AgentMachine will never end up getting an Agent without manual intervention.
This at least allows the AgentMachine to be reconciled again in the event that an existing agent does become valid.
/cc @avishayt