Bug 2037209: [Alibaba] refactor for getResourceGroup ID from name #29
Conversation
There was a problem hiding this comment.
this generally looks good to me, just a minor cleanup in the error message
@JoelSpeed ptal
pkg/actuators/machine/instances.go
Outdated
| } | ||
| if len(response.ResourceGroups.ResourceGroup) < 1 { | ||
| klog.Errorf("no resourcegroups for given name not found") | ||
| return "", fmt.Errorf("no resourcegroups for given name not found") |
There was a problem hiding this comment.
minor nit
"no resourcegroups for given name found"
|
@menglingwei: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
JoelSpeed
changed the title
openshift-ci
bot
added
the
bugzilla/severity-high
|
@menglingwei: This pull request references Bugzilla bug 2037209, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
bugzilla/valid-bug
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed, menglingwei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@menglingwei: All pull requests linked via external trackers have merged:
Bugzilla bug 2037209 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No description provided.