Update e2e test to run against machine.openshift.io #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/hold |
openshift-ci-robot
added
do-not-merge/hold
enxebre
force-pushed
the
e2e-aws-operator-machine-api
branch
from
cf4ac72
to
0c88530
Compare
openshift-ci-robot
added
size/M
enxebre
force-pushed
the
e2e-aws-operator-machine-api
branch
from
0c88530
to
c1359a7
Compare
openshift-ci-robot
added
size/S
enxebre
force-pushed
the
e2e-aws-operator-machine-api
branch
from
c1359a7
to
6c53e4e
Compare
|
/test e2e-aws-operator |
enxebre
force-pushed
the
e2e-aws-operator-machine-api
branch
from
6c53e4e
to
9c5177c
Compare
|
/lgtm |
ingvagabund
reviewed
Feb 7, 2019
test/e2e/main.go
Outdated
| @@ -59,7 +59,7 @@ func runSuite() error { | |||
| glog.Info("PASS: ExpectProviderAvailable") | |||
|
|
|||
| glog.Info("RUN: ExpectOneClusterObject") | |||
There was a problem hiding this comment.
s/ExpectOneClusterObject/ExpectNoClusterObject
There was a problem hiding this comment.
we don't need the cluster for machine.openshift.io https://github.com/openshift/cluster-api-provider-aws/pull/151/files#diff-1c49fed4c53a7b1e61a888973c253576R54
There was a problem hiding this comment.
Longer term we should have something more sophisticated so that we don't have to repeat all these string values.
enxebre
removed
the
do-not-merge/hold
enxebre
force-pushed
the
e2e-aws-operator-machine-api
branch
from
9c5177c
to
9c829de
Compare
openshift-ci-robot
added
size/M
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ingvagabund The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update e2e test to run against machine.openshift.io
Needs openshift/installer#1175