Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encrypted ebs volumes #156

Closed
wants to merge 3 commits into from
Closed

Encrypted ebs volumes #156

wants to merge 3 commits into from

Conversation

spangenberg
Copy link

No description provided.

@spangenberg
Copy link
Author

/hold

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 12, 2019
@spangenberg
Copy link
Author

/retest

@ingvagabund
Copy link
Member

/test e2e

1 similar comment
@spangenberg
Copy link
Author

/test e2e

@spangenberg
Copy link
Author

/retest

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: spangenberg

If they are not already assigned, you can assign the PR to them by writing /assign @spangenberg in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spangenberg
Copy link
Author

/test e2e-aws

@spangenberg
Copy link
Author

/test e2e-aws

@spangenberg
Copy link
Author

All of this din't make any sense, root EBS volumes are either encrypted when the AMI is private and encrypted or not if they're public or not encrypted.
The Encryption setting has to be omitted for root EBS volumes and can only be set on non root-volumes attached to the instance.

@openshift-ci-robot
Copy link

@spangenberg: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/jenkins/e2e 9339fb2 link /test e2e
ci/prow/e2e-aws 9339fb2 link /test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

michaelgugino pushed a commit to mgugino-upstream-stage/cluster-api-provider-aws that referenced this pull request Feb 12, 2020
@detiber @k8s-ci-robot
Unify tagging and edge cases (openshift#156)
f2d64b4 
- Add cluster-api-provider-aws specific tag
- Add name tags to resources we create
- handle terminated instances for bastion
- attempt to avoid orphaning eips when NAT gateway creation fails
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@spangenberg @ingvagabund @openshift-ci-robot